[Qemu-devel] [PATCH] target-ppc: add PPC_MFTB flag to e5500 core

[Qemu-devel] [PATCH] target-ppc: add PPC_MFTB flag to e5500 core

[Michael Walle]

According to the e5500 core reference manual it has support for the mftb
instruction.

Signed-off-by: Michael Walle <michael@walle.cc>
---
 target-ppc/translate_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 5ecafc7..f1261af 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -5179,7 +5179,7 @@ POWERPC_FAMILY(e5500)(ObjectClass *oc, void *data)
     dc->desc = "e5500 core";
     pcc->init_proc = init_proc_e5500;
     pcc->check_pow = check_pow_none;
-    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL |
+    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_MFTB |
                        PPC_WRTEE | PPC_RFDI | PPC_RFMCI |
                        PPC_CACHE | PPC_CACHE_LOCK | PPC_CACHE_ICBI |
                        PPC_CACHE_DCBZ | PPC_CACHE_DCBA |
-- 
2.1.4

Re: [Qemu-devel] [PATCH] target-ppc: add PPC_MFTB flag to e5500 core

[Alexander Graf]

> Am 22.07.2016 um 18:29 schrieb Michael Walle <michael@walle.cc>:
> 
> According to the e5500 core reference manual it has support for the mftb
> instruction.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

I'm surprised this didn't hit anyone before. Could you please check the other e500 cpu types too and endure consistency?

Alex

> ---
> target-ppc/translate_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 5ecafc7..f1261af 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -5179,7 +5179,7 @@ POWERPC_FAMILY(e5500)(ObjectClass *oc, void *data)
>     dc->desc = "e5500 core";
>     pcc->init_proc = init_proc_e5500;
>     pcc->check_pow = check_pow_none;
> -    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL |
> +    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_MFTB |
>                        PPC_WRTEE | PPC_RFDI | PPC_RFMCI |
>                        PPC_CACHE | PPC_CACHE_LOCK | PPC_CACHE_ICBI |
>                        PPC_CACHE_DCBZ | PPC_CACHE_DCBA |
> -- 
> 2.1.4
> 

[Qemu-devel] [PATCH v2] target-ppc: add PPC_MFTB flag to e500mc and e5500

[Michael Walle]

According to the e500mc and e5500 core reference manual they have support
for the mftb instruction.

Signed-off-by: Michael Walle <michael@walle.cc>
---
changes v2:
 - add the flag to e500mc, too

 target-ppc/translate_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 5ecafc7..5f28a36 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -5133,7 +5133,7 @@ POWERPC_FAMILY(e500mc)(ObjectClass *oc, void *data)
     dc->desc = "e500mc core";
     pcc->init_proc = init_proc_e500mc;
     pcc->check_pow = check_pow_none;
-    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL |
+    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_MFTB |
                        PPC_WRTEE | PPC_RFDI | PPC_RFMCI |
                        PPC_CACHE | PPC_CACHE_LOCK | PPC_CACHE_ICBI |
                        PPC_CACHE_DCBZ | PPC_CACHE_DCBA |
@@ -5179,7 +5179,7 @@ POWERPC_FAMILY(e5500)(ObjectClass *oc, void *data)
     dc->desc = "e5500 core";
     pcc->init_proc = init_proc_e5500;
     pcc->check_pow = check_pow_none;
-    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL |
+    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_MFTB |
                        PPC_WRTEE | PPC_RFDI | PPC_RFMCI |
                        PPC_CACHE | PPC_CACHE_LOCK | PPC_CACHE_ICBI |
                        PPC_CACHE_DCBZ | PPC_CACHE_DCBA |
-- 
2.1.4

Re: [Qemu-devel] [PATCH v2] target-ppc: add PPC_MFTB flag to e500mc and e5500

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1817 bytes --]

On Fri, Jul 22, 2016 at 06:53:51PM +0200, Michael Walle wrote:
> According to the e500mc and e5500 core reference manual they have support
> for the mftb instruction.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>

Applied to ppc-for-2.7, thanks.

> ---
> changes v2:
>  - add the flag to e500mc, too
> 
>  target-ppc/translate_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 5ecafc7..5f28a36 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -5133,7 +5133,7 @@ POWERPC_FAMILY(e500mc)(ObjectClass *oc, void *data)
>      dc->desc = "e500mc core";
>      pcc->init_proc = init_proc_e500mc;
>      pcc->check_pow = check_pow_none;
> -    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL |
> +    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_MFTB |
>                         PPC_WRTEE | PPC_RFDI | PPC_RFMCI |
>                         PPC_CACHE | PPC_CACHE_LOCK | PPC_CACHE_ICBI |
>                         PPC_CACHE_DCBZ | PPC_CACHE_DCBA |
> @@ -5179,7 +5179,7 @@ POWERPC_FAMILY(e5500)(ObjectClass *oc, void *data)
>      dc->desc = "e5500 core";
>      pcc->init_proc = init_proc_e5500;
>      pcc->check_pow = check_pow_none;
> -    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL |
> +    pcc->insns_flags = PPC_INSNS_BASE | PPC_ISEL | PPC_MFTB |
>                         PPC_WRTEE | PPC_RFDI | PPC_RFMCI |
>                         PPC_CACHE | PPC_CACHE_LOCK | PPC_CACHE_ICBI |
>                         PPC_CACHE_DCBZ | PPC_CACHE_DCBA |

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]