qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: minyard@acm.org
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <mlureau@redhat.com>, minyard@acm.org
Subject: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize
Date: Fri, 22 Jul 2016 14:50:37 -0500	[thread overview]
Message-ID: <1469217041-15358-1-git-send-email-minyard@acm.org> (raw)

Changes from v2:

Set the timers to NULL when unrealizing them, as the data structure
is still intact.

Split out the removal of the mutex from ipmi_bmc_sim to its own patch.


I did figure out a way to test these.  You can set the realize bool
in the qapi for the device to cause it to be realized/unrealized.

This has kind of opened a can of worms for me, though.  Looking 
at a lot of the devices, there is no unrealize function and that
can leave a lot of things hanging.  And for ISA bus devices, there
is no way to unregister ports.

I have a separate patch to make the BMCs not hot-pluggable and
fix up a few other small things I saw as a result of understanding
this better.  But those probably don't belong here.

Thanks,

-corey

             reply	other threads:[~2016-07-22 19:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-22 19:50 minyard [this message]
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 1/4] ipmi_bmc_sim: Remove an unnecessary mutex minyard
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 2/4] wdt_i6300esb: Free timer minyard
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 3/4] wdt_ib700: " minyard
2016-07-22 19:50 ` [Qemu-devel] [PATCH v3 4/4] ipmi_bmc_sim: Add a proper unrealize function minyard
2016-07-23  7:46 ` [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize Paolo Bonzini
2016-07-23 13:18   ` Corey Minyard
2016-07-23 15:16     ` Paolo Bonzini
2016-07-23 18:04       ` Corey Minyard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469217041-15358-1-git-send-email-minyard@acm.org \
    --to=minyard@acm.org \
    --cc=mlureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).