From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35409) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQgTC-0005d7-GL for qemu-devel@nongnu.org; Fri, 22 Jul 2016 15:50:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQgT9-0008WS-Df for qemu-devel@nongnu.org; Fri, 22 Jul 2016 15:50:50 -0400 Received: from mail-oi0-x242.google.com ([2607:f8b0:4003:c06::242]:32942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQgT9-0008Vz-8a for qemu-devel@nongnu.org; Fri, 22 Jul 2016 15:50:47 -0400 Received: by mail-oi0-x242.google.com with SMTP id l9so11280392oih.0 for ; Fri, 22 Jul 2016 12:50:46 -0700 (PDT) Sender: Corey Minyard From: minyard@acm.org Date: Fri, 22 Jul 2016 14:50:37 -0500 Message-Id: <1469217041-15358-1-git-send-email-minyard@acm.org> Subject: [Qemu-devel] [PATCH v3 0/4] Plug some memory leaks on unrealize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , minyard@acm.org Changes from v2: Set the timers to NULL when unrealizing them, as the data structure is still intact. Split out the removal of the mutex from ipmi_bmc_sim to its own patch. I did figure out a way to test these. You can set the realize bool in the qapi for the device to cause it to be realized/unrealized. This has kind of opened a can of worms for me, though. Looking at a lot of the devices, there is no unrealize function and that can leave a lot of things hanging. And for ISA bus devices, there is no way to unregister ports. I have a separate patch to make the BMCs not hot-pluggable and fix up a few other small things I saw as a result of understanding this better. But those probably don't belong here. Thanks, -corey