From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34698) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSgDY-0008GI-6o for qemu-devel@nongnu.org; Thu, 28 Jul 2016 03:58:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSgDW-0004rT-49 for qemu-devel@nongnu.org; Thu, 28 Jul 2016 03:58:55 -0400 Message-ID: <1469692703.5468.125.camel@aj.id.au> From: Andrew Jeffery Date: Thu, 28 Jul 2016 17:28:23 +0930 In-Reply-To: <947a8251-7bb6-ea6e-8bd0-05bdd89b9bc0@kaod.org> References: <1469638018-17590-1-git-send-email-clg@kaod.org> <1469638018-17590-7-git-send-email-clg@kaod.org> <1469682716.5468.114.camel@aj.id.au> <947a8251-7bb6-ea6e-8bd0-05bdd89b9bc0@kaod.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-tc+i+4+3W3l5ItKE/1W1" Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 6/6] arm: add support for an ast2500 evaluation board List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?C=E9dric?= Le Goater , Peter Maydell Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org --=-tc+i+4+3W3l5ItKE/1W1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-07-28 at 09:15 +0200, C=C3=A9dric Le Goater wrote: > >=C2=A0 > > Also, the meaning of the bits have changed from the AST2400 - they > > probably should be documented somewhere? >=20 > So you want me send to an updated version of : >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0http://lists.nongnu.org/a= rchive/html/qemu-arm/2016-06/msg00698.html >=20 > as a prereq ?=C2=A0 I mentioned this in passing due to the discussion on my original patch. I think we discussed this separately and concluded the macros were pretty verbose given they are sort-of single-use given the value doesn't change. Maybe just comments as Peter was requesting? You have the patch below but some of the macros will be different for the AST2500. I'm probably leaning towards comments over macros, but don't feel strongly either way. Andrew >=20 > Now that we have done the cleanups in U-Boot, we can pull from : >=20 > https://github.com/openbmc/u-boot/blob/v2016.07-aspeed-openbmc/arch/arm/i= nclude/asm/arch-aspeed/regs-scu.h >=20 > to get the definitions. I will add that. --=-tc+i+4+3W3l5ItKE/1W1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJXmbsfAAoJEJ0dnzgO5LT5fpcP/0VT9U8cl8CJ+iCR+oGcHN9p QuMFnyUU/umejpiL5Ea3C6Ibnj0SEeiFCRe55BQnLC76cok1p1+zo6KN8Fa5yrgh hhIgaV5zs0nRATuKnBcNIMvn82OD3KqKgFUugt7NpuTZYcAd9dTlMkfliONBITq0 19fsQ7cKLPoSQLsoCzGAq2RW7lWBQAraE3dKCPbJZkuvFnRtXvmSdw/rSbRwE4qz XbAXJlpNx1Tv6Ht5H1oFKotFAudQeeKwrAL/Nf/DvJg/MAxCtzs7wYpfylbO9C9+ Ge4XZ4dPGybp14PuCurytDvqgEu9VzqGinGG8WaK1rYp096Se21/yblqw0TtTjmZ GCk7jXr8T3o93K3kpiOA9ZgYwaHnViUghy9XmEV/Z5fTUyREAd92RqY5nejcMr9p PyC8gdPmIutyjuTCUpjWXPINGVzTm9+thbXcs2uMmkowciZtX7zC7a+Kfy3jBqTf ER9ZFYA6hp3stpxLJ1FM+xzClGvnSIefz9O0393dBQqD+RMYyZWawAOvPP7S7Po/ UmxyLUn48vE+s26uBx75YZOS6ZBvQsqwfseNggWsUxyuE9KcwlfUEOEDYrvyVOFz eZlFO84ea/7wSD3tst0zE4ehrJmBK4xshOW0cVQ9XSKDsvZX4xY5T3tR4HIy29PL V/lIAWxusOcIGzHoR5Zl =cqoG -----END PGP SIGNATURE----- --=-tc+i+4+3W3l5ItKE/1W1--