From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56146) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSu8x-00077p-OG for qemu-devel@nongnu.org; Thu, 28 Jul 2016 18:51:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSu8t-0006uo-2U for qemu-devel@nongnu.org; Thu, 28 Jul 2016 18:51:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSu8s-0006uW-TU for qemu-devel@nongnu.org; Thu, 28 Jul 2016 18:51:03 -0400 From: John Snow Date: Thu, 28 Jul 2016 18:50:58 -0400 Message-Id: <1469746258-22438-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1469746258-22438-1-git-send-email-jsnow@redhat.com> References: <1469746258-22438-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PULL 1/1] ide: fix halted IO segfault at reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, jsnow@redhat.com If one attempts to perform a system_reset after a failed IO request that causes the VM to enter a paused state, QEMU will segfault trying to free up the pending IO requests. These requests have already been completed and freed, though, so all we need to do is NULL them before we enter the paused state. Existing AHCI tests verify that halted requests are still resumed successfully after a STOP event. Analyzed-by: Laszlo Ersek Reviewed-by: Laszlo Ersek Signed-off-by: John Snow Message-id: 1469635201-11918-2-git-send-email-jsnow@redhat.com Signed-off-by: John Snow --- hw/ide/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index 081c9eb..d117b7c 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -823,6 +823,7 @@ static void ide_dma_cb(void *opaque, int ret) } if (ret < 0) { if (ide_handle_rw_error(s, -ret, ide_dma_cmd_to_retry(s->dma_cmd))) { + s->bus->dma->aiocb = NULL; return; } } -- 2.7.4