From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSyHN-0005bf-Pe for qemu-devel@nongnu.org; Thu, 28 Jul 2016 23:16:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSyHL-0002tH-VW for qemu-devel@nongnu.org; Thu, 28 Jul 2016 23:16:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSyHL-0002tB-PV for qemu-devel@nongnu.org; Thu, 28 Jul 2016 23:16:03 -0400 Date: Fri, 29 Jul 2016 06:16:00 +0300 From: "Michael S. Tsirkin" Message-ID: <1469762011-7902-17-git-send-email-mst@redhat.com> References: <1469762011-7902-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1469762011-7902-1-git-send-email-mst@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 16/41] vhost: assert the log was cleaned up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau From: Marc-Andr=E9 Lureau Make sure the log was released on cleanup, or it will leak (the alternative is to call vhost_log_put() unconditionally, but it may hide some dev state issues). Signed-off-by: Marc-Andr=E9 Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/vhost.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 9bac163..8a18f9b 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1134,6 +1134,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev) g_free(hdev->mem); g_free(hdev->mem_sections); hdev->vhost_ops->vhost_backend_cleanup(hdev); + assert(!hdev->log); QLIST_REMOVE(hdev, entry); } =20 --=20 MST