From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSzsQ-0005Nl-2J for qemu-devel@nongnu.org; Fri, 29 Jul 2016 00:58:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSzsL-0003az-3F for qemu-devel@nongnu.org; Fri, 29 Jul 2016 00:58:25 -0400 Message-ID: <1469768287.5978.251.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Fri, 29 Jul 2016 14:58:07 +1000 In-Reply-To: <1469767204.5978.244.camel@kernel.crashing.org> References: <1469571686-7284-1-git-send-email-benh@kernel.crashing.org> <1469571686-7284-28-git-send-email-benh@kernel.crashing.org> <76968d9e-1b45-538e-a400-9069eb72f42e@twiddle.net> <1469758381.5978.241.camel@kernel.crashing.org> <20160729033456.GI2588@voom.fritz.box> <1469767204.5978.244.camel@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 28/32] ppc: Avoid double translation for lvx/lvxl/stvx/stvxl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Richard Henderson , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Fri, 2016-07-29 at 14:40 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2016-07-29 at 13:34 +1000, David Gibson wrote: > >=20 > > =C2=A0 > > What should I do with this in the short term?=C2=A0=C2=A0Leave it in > > ppc-for-2.8, or remove it for now pending possible changes? >=20 > I think I'm still measuring a performance improvement with this, I'll > test a bit more and will get back to you. >=20 > It will definitely better to do it without a helper once Richard's 128- > bit stuff is in. Ok, after I nice'd myself on top of all the gcc's on that test machine I confirm that this patch is a loss on qemu-user. It might still be a win for qemu-system-ppc64 due to the translation but probably not worth bothering. So drop this one. I'll use the 128-bit support when it becomes available. Cheers, Ben.