* [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic
@ 2016-07-29 13:55 Igor Mammedov
2016-07-31 5:02 ` Michael S. Tsirkin
2016-08-01 10:02 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Igor Mammedov @ 2016-07-29 13:55 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ehabkost, pbonzini, dgilbert, peter.maydell
commit f6e98444 (apic: Use apic_id as apic's migration instance_id)
breaks migration when in kernel irqchip is used for 2.6 and older
machine types.
It applies compat property only for userspace 'apic' type
instead of applying it to all apic types inherited from
'apic-common' type as it was supposed to do.
Fix it by setting compat property 'legacy-instance-id' for
'apic-common' type which affects inherited types (i.e. not
only 'apic' but also 'kvm-apic' types)
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
include/hw/i386/pc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index c87c5c1..74c175c 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -388,7 +388,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
.value = "off",\
},\
{\
- .driver = "apic",\
+ .driver = "apic-common",\
.property = "legacy-instance-id",\
.value = "on",\
},
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic
2016-07-29 13:55 [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic Igor Mammedov
@ 2016-07-31 5:02 ` Michael S. Tsirkin
2016-08-01 10:02 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Michael S. Tsirkin @ 2016-07-31 5:02 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, ehabkost, pbonzini, dgilbert, peter.maydell
On Fri, Jul 29, 2016 at 03:55:42PM +0200, Igor Mammedov wrote:
> commit f6e98444 (apic: Use apic_id as apic's migration instance_id)
> breaks migration when in kernel irqchip is used for 2.6 and older
> machine types.
>
> It applies compat property only for userspace 'apic' type
> instead of applying it to all apic types inherited from
> 'apic-common' type as it was supposed to do.
>
> Fix it by setting compat property 'legacy-instance-id' for
> 'apic-common' type which affects inherited types (i.e. not
> only 'apic' but also 'kvm-apic' types)
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index c87c5c1..74c175c 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -388,7 +388,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> .value = "off",\
> },\
> {\
> - .driver = "apic",\
> + .driver = "apic-common",\
> .property = "legacy-instance-id",\
> .value = "on",\
> },
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic
2016-07-29 13:55 [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic Igor Mammedov
2016-07-31 5:02 ` Michael S. Tsirkin
@ 2016-08-01 10:02 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2016-08-01 10:02 UTC (permalink / raw)
To: Igor Mammedov, qemu-devel; +Cc: mst, ehabkost, dgilbert, peter.maydell
On 29/07/2016 15:55, Igor Mammedov wrote:
> commit f6e98444 (apic: Use apic_id as apic's migration instance_id)
> breaks migration when in kernel irqchip is used for 2.6 and older
> machine types.
>
> It applies compat property only for userspace 'apic' type
> instead of applying it to all apic types inherited from
> 'apic-common' type as it was supposed to do.
>
> Fix it by setting compat property 'legacy-instance-id' for
> 'apic-common' type which affects inherited types (i.e. not
> only 'apic' but also 'kvm-apic' types)
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> include/hw/i386/pc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index c87c5c1..74c175c 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -388,7 +388,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
> .value = "off",\
> },\
> {\
> - .driver = "apic",\
> + .driver = "apic-common",\
> .property = "legacy-instance-id",\
> .value = "on",\
> },
>
Queued for 2.7, thanks.
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-01 10:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-29 13:55 [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic Igor Mammedov
2016-07-31 5:02 ` Michael S. Tsirkin
2016-08-01 10:02 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).