From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUUWB-0002kP-QC for qemu-devel@nongnu.org; Tue, 02 Aug 2016 03:53:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUUW6-0001e3-0p for qemu-devel@nongnu.org; Tue, 02 Aug 2016 03:53:38 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:34015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUUW5-0001ds-Nr for qemu-devel@nongnu.org; Tue, 02 Aug 2016 03:53:33 -0400 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u727hwUc010678 for ; Tue, 2 Aug 2016 03:53:32 -0400 Received: from e28smtp03.in.ibm.com (e28smtp03.in.ibm.com [125.16.236.3]) by mx0a-001b2d01.pphosted.com with ESMTP id 24grd54fw0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 02 Aug 2016 03:53:32 -0400 Received: from localhost by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 2 Aug 2016 13:23:29 +0530 From: Nikunj A Dadhania Date: Tue, 2 Aug 2016 13:23:00 +0530 In-Reply-To: <1470124380-5751-1-git-send-email-nikunj@linux.vnet.ibm.com> References: <1470124380-5751-1-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Message-Id: <1470124380-5751-2-git-send-email-nikunj@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v1 2/2] target-ppc: cmprb - truncate RA to 8bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, rth@twiddle.net Cc: qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, anton@samba.org Missed the following bit in the instruction coding. src1 =E2=86=90 EXTZ(RA(56:63)) Reported-by: Anton Blanchard Signed-off-by: Nikunj A Dadhania --- Can be squashed with the original commit target-ppc/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-ppc/translate.c b/target-ppc/translate.c index dc89e6a..14f4b68 100644 --- a/target-ppc/translate.c +++ b/target-ppc/translate.c @@ -867,6 +867,7 @@ static void gen_cmprb(DisasContext *ctx) tcg_gen_trunc_tl_i32(src1, cpu_gpr[rA(ctx->opcode)]); tcg_gen_trunc_tl_i32(src2, cpu_gpr[rB(ctx->opcode)]); =20 + tcg_gen_andi_i32(src1, src1, 0xFF); tcg_gen_ext8u_i32(src2lo, src2); tcg_gen_shri_i32(src2, src2, 8); tcg_gen_ext8u_i32(src2hi, src2); --=20 2.7.4