From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUbI1-0002GJ-86 for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:07:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUbHu-0003HH-FU for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:07:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUbHu-0003HC-9p for qemu-devel@nongnu.org; Tue, 02 Aug 2016 11:07:22 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF6E24481C for ; Tue, 2 Aug 2016 15:07:21 +0000 (UTC) From: Colin Lord Date: Tue, 2 Aug 2016 11:07:18 -0400 Message-Id: <1470150439-28468-2-git-send-email-clord@redhat.com> In-Reply-To: <1470150439-28468-1-git-send-email-clord@redhat.com> References: <1470150439-28468-1-git-send-email-clord@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] rules.mak: Don't extract libs from .mo-libs in link command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, kraxel@redhat.com, Fam Zheng From: Fam Zheng For module build, .mo objects are passed to LINK and consumed in process-archive-undefs. The reason behind that is documented in the comment above process-archive-undefs. Similarly, extract-libs should be called with .mo filtered out too. Otherwise, the .mo-libs are added to the link command incorrectly, spoiling the purpose of modularization. Currently we don't have any .mo-libs usage, but it will be used soon when we modularize more multi-source objects, like sdl and gtk. Reported-by: Colin Lord Signed-off-by: Fam Zheng --- rules.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rules.mak b/rules.mak index 99cd0b3..1211649 100644 --- a/rules.mak +++ b/rules.mak @@ -50,7 +50,7 @@ process-archive-undefs = $(filter-out %.a %.mo,$1) \ $(call undefined-symbols,$(filter %.mo,$1)))) \ $(filter %.a,$1) -extract-libs = $(strip $(foreach o,$1,$($o-libs))) +extract-libs = $(strip $(foreach o,$(filter-out %.mo,$1),$($o-libs))) expand-objs = $(strip $(sort $(filter %.o,$1)) \ $(foreach o,$(filter %.mo,$1),$($o-objs)) \ $(filter-out %.o %.mo,$1)) -- 2.5.5