From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit hosts
Date: Wed, 03 Aug 2016 20:51:56 +1000 [thread overview]
Message-ID: <1470221516.12584.81.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAFEAcA8KVKzuPNQMa2fV6P+DXQX0x9=MGFWzg_EJVAzOnfUcFg@mail.gmail.com>
On Wed, 2016-08-03 at 11:48 +0100, Peter Maydell wrote:
> > As to why you don't hit the bug on ARM, well, maybe you don't
> > many helpers using tlb_vaddr_to_host ? Also address randomization makes
> > things hit or miss here ...
>
> The only uses of tlb_vaddr_to_host in the tree are
> (a) in a not-CONFIG_USER_ONLY codepath on target-arm
> (b) in target-s390x, which is a 64-bit guest
(c) a few new helpers using it on ppc that are in David's ppc-for-2.8
branch :-)
Now we can put the fix in his branch if you prefer but it's a pretty
trivial one so I would suggest just sticking it in.
Cheers,
Ben
prev parent reply other threads:[~2016-08-03 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 3:15 [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit hosts Benjamin Herrenschmidt
2016-08-03 8:40 ` Peter Maydell
2016-08-03 9:50 ` Benjamin Herrenschmidt
2016-08-03 10:18 ` Benjamin Herrenschmidt
2016-08-03 10:48 ` Peter Maydell
2016-08-03 10:51 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470221516.12584.81.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).