From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36668)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bUtmR-0001WV-ND
	for qemu-devel@nongnu.org; Wed, 03 Aug 2016 06:52:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bUtmM-0007S2-M4
	for qemu-devel@nongnu.org; Wed, 03 Aug 2016 06:52:06 -0400
Received: from gate.crashing.org ([63.228.1.57]:38462)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bUtmM-0007Rx-BM
	for qemu-devel@nongnu.org; Wed, 03 Aug 2016 06:52:02 -0400
Message-ID: <1470221516.12584.81.camel@kernel.crashing.org>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Wed, 03 Aug 2016 20:51:56 +1000
In-Reply-To: <CAFEAcA8KVKzuPNQMa2fV6P+DXQX0x9=MGFWzg_EJVAzOnfUcFg@mail.gmail.com>
References: <1470194119.12584.43.camel@kernel.crashing.org>
	<CAFEAcA9LK_Ew=oxmJM9qoF_Ar6YrPJvxdPgzrmpgFmmr-wBQ5A@mail.gmail.com>
	<1470217830.12584.70.camel@kernel.crashing.org>
	<1470219512.12584.78.camel@kernel.crashing.org>
	<CAFEAcA8KVKzuPNQMa2fV6P+DXQX0x9=MGFWzg_EJVAzOnfUcFg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] Fix g2h() for 32-bit targets on 64-bit
 hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On Wed, 2016-08-03 at 11:48 +0100, Peter Maydell wrote:
> > As to why you don't hit the bug on ARM, well, maybe you don't
> > many helpers using tlb_vaddr_to_host ? Also address randomization mak=
es
> > things hit or miss here ...
>=20
> The only uses of tlb_vaddr_to_host in the tree are
> (a) in a not-CONFIG_USER_ONLY codepath on target-arm
> (b) in target-s390x, which is a 64-bit guest

=C2=A0 (c) a few new helpers using it on ppc that are in David's ppc-for-=
2.8=20
branch :-)

Now we can put the fix in his branch if you prefer but it's a pretty
trivial one so I would suggest just sticking it in.

Cheers,
Ben