From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43452) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUuFD-0000jU-Kv for qemu-devel@nongnu.org; Wed, 03 Aug 2016 07:21:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUuFB-0006FE-KW for qemu-devel@nongnu.org; Wed, 03 Aug 2016 07:21:50 -0400 From: Kevin Wolf Date: Wed, 3 Aug 2016 13:21:27 +0200 Message-Id: <1470223294-3870-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1470223294-3870-1-git-send-email-kwolf@redhat.com> References: <1470223294-3870-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v5 04/11] block: Accept node-name for blockdev-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, mreitz@redhat.com, eblake@redhat.com, berto@igalia.com, qemu-devel@nongnu.org In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-mirror to accept a node-name without lifting the restriction that we're operating at a root node. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- blockdev.c | 10 +--------- qapi/block-core.json | 3 ++- qmp-commands.hx | 3 ++- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/blockdev.c b/blockdev.c index 46beafd..ccff1f7 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3627,21 +3627,13 @@ void qmp_blockdev_mirror(bool has_job_id, const char *job_id, Error **errp) { BlockDriverState *bs; - BlockBackend *blk; BlockDriverState *target_bs; AioContext *aio_context; BlockMirrorBackingMode backing_mode = MIRROR_LEAVE_BACKING_CHAIN; Error *local_err = NULL; - blk = blk_by_name(device); - if (!blk) { - error_setg(errp, "Device '%s' not found", device); - return; - } - bs = blk_bs(blk); - + bs = qmp_get_root_bs(device, errp); if (!bs) { - error_setg(errp, "Device '%s' has no media", device); return; } diff --git a/qapi/block-core.json b/qapi/block-core.json index 53f46b6..bcb37db 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -1277,7 +1277,8 @@ # @job-id: #optional identifier for the newly-created block job. If # omitted, the device name will be used. (Since 2.7) # -# @device: the name of the device whose writes should be mirrored. +# @device: The device name or node-name of a root node whose writes should be +# mirrored. # # @target: the id or node-name of the block device to mirror to. This mustn't be # attached to guest. diff --git a/qmp-commands.hx b/qmp-commands.hx index d3ba48d..6af1e58 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -1747,7 +1747,8 @@ Arguments: - "job-id": Identifier for the newly-created block job. If omitted, the device name will be used. (json-string, optional) -- "device": device name to operate on (json-string) +- "device": The device name or node-name of a root node whose writes should be + mirrored (json-string) - "target": device name to mirror to (json-string) - "replaces": the block driver node name to replace when finished (json-string, optional) -- 1.8.3.1