From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVbN7-0003CU-HR for qemu-devel@nongnu.org; Fri, 05 Aug 2016 05:24:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVbN5-0000Og-I0 for qemu-devel@nongnu.org; Fri, 05 Aug 2016 05:24:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVbN5-0000Oa-CW for qemu-devel@nongnu.org; Fri, 05 Aug 2016 05:24:51 -0400 From: Stefan Hajnoczi Date: Fri, 5 Aug 2016 10:24:40 +0100 Message-Id: <1470389082-15298-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1470389082-15298-1-git-send-email-stefanha@redhat.com> References: <1470389082-15298-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL for-2.7 3/5] throttle: Test burst limits lower than the normal limits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Alberto Garcia , Stefan Hajnoczi From: Alberto Garcia This checks that making FOO_max lower than FOO is not allowed. We could also forbid having FOO_max == FOO, but that doesn't have any odd side effects and it would require us to update several other tests, so let's keep it simple. Signed-off-by: Alberto Garcia Reviewed-by: Eric Blake Message-id: 2f90f9ee58aa14b7bd985f67c5996b06e0ab6c19.1469693110.git.berto@igalia.com Signed-off-by: Stefan Hajnoczi --- tests/test-throttle.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tests/test-throttle.c b/tests/test-throttle.c index afe094b..363b59a 100644 --- a/tests/test-throttle.c +++ b/tests/test-throttle.c @@ -394,6 +394,14 @@ static void test_max_is_missing_limit(void) cfg.buckets[i].max = 0; cfg.buckets[i].avg = 100; g_assert(throttle_is_valid(&cfg, NULL)); + + cfg.buckets[i].max = 30; + cfg.buckets[i].avg = 100; + g_assert(!throttle_is_valid(&cfg, NULL)); + + cfg.buckets[i].max = 100; + cfg.buckets[i].avg = 100; + g_assert(throttle_is_valid(&cfg, NULL)); } } -- 2.7.4