From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL for-2.7 5/5] virtio-blk: Remove stale comment about draining
Date: Fri, 5 Aug 2016 10:24:42 +0100 [thread overview]
Message-ID: <1470389082-15298-6-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1470389082-15298-1-git-send-email-stefanha@redhat.com>
From: Fam Zheng <famz@redhat.com>
This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to
drain IO requests), remove it.
Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Message-id: 1470278654-13525-3-git-send-email-famz@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/block/virtio-blk.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 1e348b1..331d766 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -656,10 +656,6 @@ static void virtio_blk_reset(VirtIODevice *vdev)
AioContext *ctx;
VirtIOBlockReq *req;
- /*
- * This should cancel pending requests, but can't do nicely until there
- * are per-device request lists.
- */
ctx = blk_get_aio_context(s->blk);
aio_context_acquire(ctx);
blk_drain(s->blk);
--
2.7.4
next prev parent reply other threads:[~2016-08-05 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 9:24 [Qemu-devel] [PULL for-2.7 0/5] Block patches Stefan Hajnoczi
2016-08-05 9:24 ` [Qemu-devel] [PULL for-2.7 1/5] block/parallels: check new image size Stefan Hajnoczi
2016-08-05 9:24 ` [Qemu-devel] [PULL for-2.7 2/5] throttle: Don't allow burst limits to be lower than the normal limits Stefan Hajnoczi
2016-08-05 9:24 ` [Qemu-devel] [PULL for-2.7 3/5] throttle: Test burst limits " Stefan Hajnoczi
2016-08-05 9:24 ` [Qemu-devel] [PULL for-2.7 4/5] virtio-blk: Release s->rq queue at system_reset Stefan Hajnoczi
2016-08-05 9:24 ` Stefan Hajnoczi [this message]
2016-08-05 12:05 ` [Qemu-devel] [PULL for-2.7 0/5] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470389082-15298-6-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).