From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVbz4-0000OD-Qr for qemu-devel@nongnu.org; Fri, 05 Aug 2016 06:04:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVbz2-0003eU-Td for qemu-devel@nongnu.org; Fri, 05 Aug 2016 06:04:05 -0400 Received: from orth.archaic.org.uk ([2001:8b0:1d0::2]:58553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVbz2-0003eQ-N4 for qemu-devel@nongnu.org; Fri, 05 Aug 2016 06:04:04 -0400 From: Peter Maydell Date: Fri, 5 Aug 2016 11:03:59 +0100 Message-Id: <1470391439-28427-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] hw/sparc/leon3: Don't call get_image_size() on a NULL pointer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org, Fabien Chouteau , Mark Cave-Ayland , Artyom Tarasenko get_image_size() doesn't handle being passed a NULL pointer, so avoid doing that. Spotted by the clang ub sanitizer (which notices the attempt to pass NULL to open()). Signed-off-by: Peter Maydell --- hw/sparc/leon3.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c index dbae41f..6e16478 100644 --- a/hw/sparc/leon3.c +++ b/hw/sparc/leon3.c @@ -171,7 +171,11 @@ static void leon3_generic_hw_init(MachineState *machine) } filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, bios_name); - bios_size = get_image_size(filename); + if (filename) { + bios_size = get_image_size(filename); + } else { + bios_size = -1; + } if (bios_size > prom_size) { fprintf(stderr, "qemu: could not load prom '%s': file too big\n", -- 2.7.4