qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-ppc@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>,
	Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object
Date: Sat, 06 Aug 2016 08:43:21 +1000	[thread overview]
Message-ID: <1470437001.12584.170.camel@kernel.crashing.org> (raw)
In-Reply-To: <c1288a07-175b-19ba-5f84-2af016dba3ee@kaod.org>

On Fri, 2016-08-05 at 18:48 +0200, Cédric Le Goater wrote:
> The core initialization should be ok but building the device 
> tree might be a bit of a burden if we have to 'cast' in the chip 
> type we need. We will see.

We don't cast, we use a method.

> So what would be the big differences with what we have today ?   

The XSCOM controller has a different address decoding scheme, so
we'll have two variants and a base class there. The number and
location of functional units changes, so we'll probably need to make
them properties or something, the core XSCOM addressing is completely
different, we use PHB4 rather than PHB3, etc...

(Note that for PHB we should probably rename PHB3 to PnvPhb with a
subclass as well as there is a lot in common between the two, though
the PBCQ bit is quite different).

Cheers,
Ben.

  reply	other threads:[~2016-08-05 22:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-05  9:15 [Qemu-devel] [PATCH 0/3] ppc/pnc: add a minimal platform Cédric Le Goater
2016-08-05  9:15 ` [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform Cédric Le Goater
2016-08-16  2:12   ` David Gibson
2016-08-26 14:47     ` Cédric Le Goater
2016-08-26 22:48       ` Benjamin Herrenschmidt
2016-08-29 14:17         ` David Gibson
2016-08-29 14:16       ` David Gibson
2016-08-05  9:15 ` [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object Cédric Le Goater
2016-08-05  9:44   ` Benjamin Herrenschmidt
2016-08-05 16:48     ` Cédric Le Goater
2016-08-05 22:43       ` Benjamin Herrenschmidt [this message]
2016-08-16  2:18         ` David Gibson
2016-08-16  2:21   ` David Gibson
2016-08-26 16:31     ` Cédric Le Goater
2016-08-05  9:15 ` [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object Cédric Le Goater
2016-08-16  2:39   ` David Gibson
2016-08-16  5:02     ` Benjamin Herrenschmidt
2016-08-26 17:55       ` Cédric Le Goater
2016-08-26 17:49     ` Cédric Le Goater
2016-08-29 14:30       ` David Gibson
2016-08-30  6:15         ` Benjamin Herrenschmidt
2016-08-30  6:28           ` David Gibson
2016-08-31  1:06             ` Benjamin Herrenschmidt
2016-08-30  7:23           ` Cédric Le Goater
2016-09-05  1:45             ` David Gibson
2016-09-06  7:45               ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470437001.12584.170.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=agraf@suse.de \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).