From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bVnq9-0004xO-R7 for qemu-devel@nongnu.org; Fri, 05 Aug 2016 18:43:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bVnq4-0000Kb-Pc for qemu-devel@nongnu.org; Fri, 05 Aug 2016 18:43:40 -0400 Message-ID: <1470437001.12584.170.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Sat, 06 Aug 2016 08:43:21 +1000 In-Reply-To: References: <1470388537-2908-1-git-send-email-clg@kaod.org> <1470388537-2908-3-git-send-email-clg@kaod.org> <1470390251.12584.157.camel@kernel.crashing.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?C=E9dric?= Le Goater , qemu-ppc@nongnu.org Cc: David Gibson , Alexander Graf , qemu-devel@nongnu.org On Fri, 2016-08-05 at 18:48 +0200, C=C3=A9dric Le Goater wrote: > The core initialization should be ok but building the device=C2=A0 > tree might be a bit of a burden if we have to 'cast' in the chip=C2=A0 > type we need. We will see. We don't cast, we use a method. > So what would be the big differences with what we have today ?=C2=A0=C2= =A0=C2=A0 The XSCOM controller has a different address decoding scheme, so we'll have two variants and a base class there. The number and location of functional units changes, so we'll probably need to make them properties or something, the core XSCOM addressing is completely different, we use PHB4 rather than PHB3, etc... (Note that for PHB we should probably rename PHB3 to PnvPhb with a subclass as well as there is a lot in common between the two, though the PBCQ bit is quite different). Cheers, Ben.