* [Qemu-devel] [PATCH] ivshmem: Delete duplicate debug message
@ 2016-08-07 10:09 Stefano Dong (董兴水)
2016-08-07 14:27 ` Marc-André Lureau
2016-08-08 9:43 ` Markus Armbruster
0 siblings, 2 replies; 4+ messages in thread
From: Stefano Dong (董兴水) @ 2016-08-07 10:09 UTC (permalink / raw)
To: armbru, mst, pbonzini; +Cc: qemu-devel, opensource.dxs
When Debug switch is open, this debug message will print again in
function 'process_msg'. Delete it.
Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com>
---
hw/misc/ivshmem.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index 40a2ebc..f803dfd 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -628,7 +628,6 @@ static void ivshmem_read(void *opaque, const uint8_t *buf, int size)
s->msg_buffered_bytes = 0;
fd = qemu_chr_fe_get_msgfd(s->server_chr);
- IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
process_msg(s, msg, fd, &err);
if (err) {
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ivshmem: Delete duplicate debug message
2016-08-07 10:09 [Qemu-devel] [PATCH] ivshmem: Delete duplicate debug message Stefano Dong (董兴水)
@ 2016-08-07 14:27 ` Marc-André Lureau
2016-08-08 9:43 ` Markus Armbruster
1 sibling, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2016-08-07 14:27 UTC (permalink / raw)
To: Stefano Dong (董兴水), armbru, mst, pbonzini; +Cc: qemu-devel
On Sun, Aug 7, 2016 at 5:48 PM Stefano Dong (董兴水) <opensource.dxs@aliyun.com>
wrote:
> When Debug switch is open, this debug message will print again in
> function 'process_msg'. Delete it.
>
> Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> hw/misc/ivshmem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index 40a2ebc..f803dfd 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -628,7 +628,6 @@ static void ivshmem_read(void *opaque, const uint8_t
> *buf, int size)
> s->msg_buffered_bytes = 0;
>
> fd = qemu_chr_fe_get_msgfd(s->server_chr);
> - IVSHMEM_DPRINTF("posn is %" PRId64 ", fd is %d\n", msg, fd);
>
> process_msg(s, msg, fd, &err);
> if (err) {
> --
> 2.7.4
>
>
> --
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] ivshmem: Delete duplicate debug message
2016-08-07 10:09 [Qemu-devel] [PATCH] ivshmem: Delete duplicate debug message Stefano Dong (董兴水)
2016-08-07 14:27 ` Marc-André Lureau
@ 2016-08-08 9:43 ` Markus Armbruster
2016-08-09 22:23 ` Stefano Dong (董兴水)
1 sibling, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2016-08-08 9:43 UTC (permalink / raw)
To: Stefano Dong (董兴水)
Cc: mst, pbonzini, qemu-devel, qemu-trivial
This could go in via qemu-trivial.
Stefano Dong (董兴水) <opensource.dxs@aliyun.com> writes:
> When Debug switch is open, this debug message will print again in
> function 'process_msg'. Delete it.
Suggest to say "Duplicated in commit ca0b756. Delete it."
> Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] ivshmem: Delete duplicate debug message
2016-08-08 9:43 ` Markus Armbruster
@ 2016-08-09 22:23 ` Stefano Dong (董兴水)
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Dong (董兴水) @ 2016-08-09 22:23 UTC (permalink / raw)
To: Markus Armbruster; +Cc: mst, pbonzini, qemu-devel, qemu-trivial, opensource.dxs
On 2016年08月08日 17:43, Markus Armbruster wrote:
> This could go in via qemu-trivial.
>
> Stefano Dong (董兴水) <opensource.dxs@aliyun.com> writes:
>
>> When Debug switch is open, this debug message will print again in
>> function 'process_msg'. Delete it.
>
> Suggest to say "Duplicated in commit ca0b756. Delete it."
Ok, i'll update the log message and send the patch to qemu-trivial.
Thanks!
>
>> Signed-off-by: Stefano Dong (董兴水) <opensource.dxs@aliyun.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-09 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-07 10:09 [Qemu-devel] [PATCH] ivshmem: Delete duplicate debug message Stefano Dong (董兴水)
2016-08-07 14:27 ` Marc-André Lureau
2016-08-08 9:43 ` Markus Armbruster
2016-08-09 22:23 ` Stefano Dong (董兴水)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).