From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX3e5-0008AL-Uf for qemu-devel@nongnu.org; Tue, 09 Aug 2016 05:48:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bX3e1-0008S7-Pr for qemu-devel@nongnu.org; Tue, 09 Aug 2016 05:48:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bX3e1-0008S2-Jd for qemu-devel@nongnu.org; Tue, 09 Aug 2016 05:48:21 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DD0C761E5E for ; Tue, 9 Aug 2016 09:48:20 +0000 (UTC) From: Prasanna Kumar Kalever Date: Tue, 9 Aug 2016 15:18:14 +0530 Message-Id: <1470736094-19194-1-git-send-email-prasanna.kalever@redhat.com> Subject: [Qemu-devel] [PATCH v1 1/1] block/gluster: fix port type in the QAPI options list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, eblake@redhat.com, jcody@redhat.com, areis@redhat.com, vbellur@redhat.com, Prasanna Kumar Kalever After introduction of qapi schema in gluster block driver code, the port type is now string as per InetSocketAddress { 'struct': 'InetSocketAddress', 'data': { 'host': 'str', 'port': 'str', '*to': 'uint16', '*ipv4': 'bool', '*ipv6': 'bool' } } but the current code still treats it as QEMU_OPT_NUMBER, hence fixing port to accept QEMU_OPT_STRING. Credits: Markus Armbruster Signed-off-by: Prasanna Kumar Kalever --- block/gluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/gluster.c b/block/gluster.c index edde1ad..e6afa48 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -161,7 +161,7 @@ static QemuOptsList runtime_tcp_opts = { }, { .name = GLUSTER_OPT_PORT, - .type = QEMU_OPT_NUMBER, + .type = QEMU_OPT_STRING, .help = "port number on which glusterd is listening (default 24007)", }, { -- 2.7.4