From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXMIs-0006n2-Qv for qemu-devel@nongnu.org; Wed, 10 Aug 2016 01:43:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXMIr-0001SJ-W3 for qemu-devel@nongnu.org; Wed, 10 Aug 2016 01:43:46 -0400 From: David Gibson Date: Wed, 10 Aug 2016 15:45:36 +1000 Message-Id: <1470807941-25931-2-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1470807941-25931-1-git-send-email-david@gibson.dropbear.id.au> References: <1470807941-25931-1-git-send-email-david@gibson.dropbear.id.au> Subject: [Qemu-devel] [PULL 1/6] ppc64: fix compressed dump with pseries kernel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de, thuth@redhat.com, lvivier@redhat.com, bharata@linux.vnet.ibm.com, imammedo@redhat.com, David Gibson From: Laurent Vivier If we don't provide the page size in target-ppc:cpu_get_dump_info(), the default one (TARGET_PAGE_SIZE, 4KB) is used to create the compressed dump. It works fine with Macintosh, but not with pseries as the kernel default page size is 64KB. Without this patch, if we generate a compressed dump in the QEMU monitor: (qemu) dump-guest-memory -z qemu.dump This dump cannot be read by crash: # crash vmlinux qemu.dump ... WARNING: cannot translate vmemmap kernel virtual addresses: commands requiring page structure contents will fail ... Page_size is used to determine the dumpfile's block size. The block size needs to be at least the page size, but a multiple of page size works fine too. For PPC64, linux supports either 4KB or 64KB software page size. So we define the page_size to 64KB. Signed-off-by: Laurent Vivier Reviewed-by: Andrew Jones Signed-off-by: David Gibson --- target-ppc/arch_dump.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target-ppc/arch_dump.c b/target-ppc/arch_dump.c index df1fd8c..40282a1 100644 --- a/target-ppc/arch_dump.c +++ b/target-ppc/arch_dump.c @@ -220,6 +220,11 @@ int cpu_get_dump_info(ArchDumpInfo *info, } else { info->d_endian = ELFDATA2LSB; } + /* 64KB is the max page size for pseries kernel */ + if (strncmp(object_get_typename(qdev_get_machine()), + "pseries-", 8) == 0) { + info->page_size = (1U << 16); + } return 0; } -- 2.7.4