qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: thuth@redhat.com, armbru@redhat.com, famz@redhat.com,
	cornelia.huck@de.ibm.com
Subject: [Qemu-devel] [PATCH 2/5] checkpatch: check for CVS keywords on all sources
Date: Wed, 10 Aug 2016 10:22:47 +0200	[thread overview]
Message-ID: <1470817370-145190-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1470817370-145190-1-git-send-email-pbonzini@redhat.com>

These should apply to all files, not just C/C++.  Tweak the regular
expression to check for whole words, to avoid false positives on Perl
variables starting with "Id".

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/checkpatch.pl | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 082c4ce..f6928db 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1354,6 +1354,11 @@ sub process {
 			WARN("adding a line without newline at end of file\n" . $herecurr);
 		}
 
+# check for RCS/CVS revision markers
+		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|\b)/) {
+			WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
+		}
+
 # tabs are only allowed in assembly source code, and in
 # some scripts we imported from other projects.
 		next if ($realfile =~ /\.(s|S)$/);
@@ -1368,11 +1373,6 @@ sub process {
 # check we are in a valid C source file if not then ignore this hunk
 		next if ($realfile !~ /\.(h|c|cpp)$/);
 
-# check for RCS/CVS revision markers
-		if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
-			WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
-		}
-
 # Check for potential 'bare' types
 		my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
 		    $realline_next);
-- 
1.8.3.1

  parent reply	other threads:[~2016-08-10  8:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  8:22 [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks Paolo Bonzini
2016-08-10  8:22 ` [Qemu-devel] [PATCH 1/5] checkpatch: tweak the files in which TABs are checked Paolo Bonzini
2016-08-10  8:57   ` Cornelia Huck
2016-08-10  9:02     ` Paolo Bonzini
2016-08-10  9:05       ` Cornelia Huck
2016-08-10  8:22 ` Paolo Bonzini [this message]
2016-08-10  8:22 ` [Qemu-devel] [PATCH 3/5] CODING_STYLE, checkpatch: update line length rules Paolo Bonzini
2016-08-10  9:01   ` Cornelia Huck
2016-08-10  9:48   ` Thomas Huth
2016-08-10  8:22 ` [Qemu-devel] [PATCH 4/5] checkpatch: bump most warnings to errors Paolo Bonzini
2016-08-10  9:54   ` Thomas Huth
2016-08-10 10:25     ` Paolo Bonzini
2016-08-10 10:29       ` Thomas Huth
2016-08-10 10:44         ` Paolo Bonzini
2016-08-10 10:48           ` Thomas Huth
2016-08-10  8:22 ` [Qemu-devel] [PATCH 5/5] checkpatch: default to success if only warnings Paolo Bonzini
2016-08-10  9:03 ` [Qemu-devel] [PATCH v2 0/5] checkpatch tweaks Markus Armbruster
2016-08-10 23:56 ` no-reply
2016-08-10 23:55   ` Fam Zheng
2016-08-11  0:02 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470817370-145190-3-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).