qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Bolognani <abologna@redhat.com>
To: bharata@linux.vnet.ibm.com, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, david@gibson.dropbear.id.au, groug@kaod.org,
	thuth@redhat.com, imammedo@redhat.com, ehabkost@redhat.com,
	sbhat@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] spapr: CPU compat option works only with -global for pseries-2.7
Date: Wed, 10 Aug 2016 17:54:40 +0200	[thread overview]
Message-ID: <1470844480.3959.14.camel@redhat.com> (raw)
In-Reply-To: <20160810144116.GA4514@in.ibm.com>

On Wed, 2016-08-10 at 20:11 +0530, Bharata B Rao wrote:
> Hi,
> 
> With CPU core hotplug support in pseries-2.7, we will have to specify
> the compat type using -global only as we don't yet take care of parsing
> -cpu cputype,compat=.
> 
> There have been patches to support that:
> 
> sPAPR specific one: https://lists.nongnu.org/archive/html/qemu-devel/2016-06/msg07564.html
> 
> PPC generic one: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg02676.html
> 
> but the patch isn't upstream yet.
> 
> The result is that instead of specifying
> 
> -cpu host,compat=power7 for pseries-2.7, we will have to use
> 
> -cpu host -global driver=host-powerpc64-cpu,property=compat,value=power7
> 
> This behaviour is specific to pseries-2.7 and for earlier machine types
> the original way of specifying compat with -cpu works.
> 
> Will this be a concern for libvirt ? Would it be difficult for libvirt to
> switch to -global when generating QEMU cmdline for compat mode for pseries-2.7
> machine.
> 
> Or, should we just include one of the above patches so that
> -cpu cputype,compat= continues to work for peseries-2.7 ?

I filed bugs for this yesterday:

  https://bugzilla.redhat.com/1365643 (QEMU)
  https://bugzilla.redhat.com/1365647 (libvirt)

libvirt could certainly be adapted to use -global, but that
would not benefit people running QEMU directly, or driving
QEMU 2.7 with any existing libvirt version.

Plus, it would not solve the issue with CPU models that
include a dot in their names, as you already noted.

I won't comment on the patches because I'm not qualified to :)

But, assuming they both restore the previous behaviour,
getting either one into 2.7 would definitely be great.

-- 
Andrea Bolognani / Red Hat / Virtualization

      parent reply	other threads:[~2016-08-10 15:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10 14:41 [Qemu-devel] spapr: CPU compat option works only with -global for pseries-2.7 Bharata B Rao
2016-08-10 14:52 ` Eduardo Habkost
2016-08-10 15:05   ` Eduardo Habkost
2016-08-10 15:54 ` Andrea Bolognani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1470844480.3959.14.camel@redhat.com \
    --to=abologna@redhat.com \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=ehabkost@redhat.com \
    --cc=groug@kaod.org \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=sbhat@linux.vnet.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).