qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter
@ 2016-08-06 17:51 Ashijeet Acharya
  2016-08-09 17:16 ` Ashijeet Acharya
  0 siblings, 1 reply; 16+ messages in thread
From: Ashijeet Acharya @ 2016-08-06 17:51 UTC (permalink / raw)
  To: QEMU Developers, jsnow

Hi,

I was working on a patch regarding a device lifecycle bitesize task
and I wanted to clear my queries about what the task is exactly.

Do I need to create a new function ahci_unrealize() in the
hw/ide/ahci.c file which calls for qemu_del_vm_change_state_handler()
to free the handler at the time of ahci hot unplug.

Please tell me if I am on the right path and correct me if I am wrong.

Thanks
Ashijeet

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()
@ 2016-08-16 17:10 Ashijeet Acharya
  2016-09-01  5:31 ` Ashijeet Acharya
  0 siblings, 1 reply; 16+ messages in thread
From: Ashijeet Acharya @ 2016-08-16 17:10 UTC (permalink / raw)
  To: jsnow; +Cc: pbonzini, qemu-devel, Ashijeet Acharya

Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash.

Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
---
 hw/ide/core.c             |  2 +-
 hw/ide/qdev.c             | 14 ++++++++++++++
 include/hw/ide/internal.h |  1 +
 3 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/hw/ide/core.c b/hw/ide/core.c
index 45b6df1..eecbb47 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2582,7 +2582,7 @@ static void ide_restart_cb(void *opaque, int running, RunState state)
 void ide_register_restart_cb(IDEBus *bus)
 {
     if (bus->dma->ops->restart_dma) {
-        qemu_add_vm_change_state_handler(ide_restart_cb, bus);
+        bus->vmstate = qemu_add_vm_change_state_handler(ide_restart_cb, bus);
     }
 }
 
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 67c76bf..6f75f77 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -31,6 +31,7 @@
 /* --------------------------------- */
 
 static char *idebus_get_fw_dev_path(DeviceState *dev);
+static void idebus_unrealize(DeviceState *qdev, Error **errp);
 
 static Property ide_props[] = {
     DEFINE_PROP_UINT32("unit", IDEDevice, unit, -1),
@@ -345,6 +346,7 @@ static void ide_device_class_init(ObjectClass *klass, void *data)
     k->init = ide_qdev_init;
     set_bit(DEVICE_CATEGORY_STORAGE, k->categories);
     k->bus_type = TYPE_IDE_BUS;
+    k->unrealize = idebus_unrealize;
     k->props = ide_props;
 }
 
@@ -368,3 +370,15 @@ static void ide_register_types(void)
 }
 
 type_init(ide_register_types)
+
+static void idebus_unrealize(DeviceState *qdev, Error **errp)
+{
+    IDEBus *bus = DO_UPCAST(IDEBus, qbus, qdev->parent_bus);
+
+    if (bus->dma->ops->restart_dma) {
+        if (bus->vmstate) {
+            qemu_del_vm_change_state_handler(bus->vmstate);
+        }
+    }
+}

diff --git a/include/hw/ide/internal.h b/include/hw/ide/internal.h
index 7824bc3..2103261 100644
--- a/include/hw/ide/internal.h
+++ b/include/hw/ide/internal.h
@@ -480,6 +480,7 @@ struct IDEBus {
     uint8_t retry_unit;
     int64_t retry_sector_num;
     uint32_t retry_nsector;
+    VMChangeStateEntry *vmstate;
 };
 
 #define TYPE_IDE_DEVICE "ide-device"
-- 
2.6.2

^ permalink raw reply related	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2016-09-01 15:46 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-06 17:51 [Qemu-devel] Dangling change state handler while hot unplugging ahci adapter Ashijeet Acharya
2016-08-09 17:16 ` Ashijeet Acharya
2016-08-09 18:18   ` John Snow
2016-08-10  5:42     ` Ashijeet Acharya
2016-08-11  8:20       ` Ashijeet Acharya
2016-08-11 16:20         ` Ashijeet Acharya
2016-08-11 16:34           ` Paolo Bonzini
2016-08-11 16:40             ` Ashijeet Acharya
2016-08-11 18:45               ` [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb() Ashijeet Acharya
2016-08-12  9:58                 ` Paolo Bonzini
2016-08-16 13:55                   ` Ashijeet Acharya
2016-08-16 17:08                     ` John Snow
  -- strict thread matches above, loose matches on Subject: below --
2016-08-16 17:10 Ashijeet Acharya
2016-09-01  5:31 ` Ashijeet Acharya
2016-09-01 15:43   ` Paolo Bonzini
2016-09-01 15:45     ` Ashijeet Acharya

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).