[Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

[Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

[Thomas Huth]

In the QEMU monitor pane of the gtk user interface, the backspace
key is not working at all. This happens because of a missing mapping
of the key in the qcode_to_keysym[] table. Thus let's add an entry
there to get the backspace key working again.

Buglink: https://bugs.launchpad.net/qemu/+bug/1611979
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 ui/console.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ui/console.c b/ui/console.c
index c24bfe4..3940762 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -1142,6 +1142,7 @@ static const int qcode_to_keysym[Q_KEY_CODE__MAX] = {
     [Q_KEY_CODE_PGUP]   = QEMU_KEY_PAGEUP,
     [Q_KEY_CODE_PGDN]   = QEMU_KEY_PAGEDOWN,
     [Q_KEY_CODE_DELETE] = QEMU_KEY_DELETE,
+    [Q_KEY_CODE_BACKSPACE] = QEMU_KEY_BACKSPACE,
 };
 
 bool kbd_put_qcode_console(QemuConsole *s, int qcode)
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

[Gerd Hoffmann]

On Do, 2016-08-11 at 09:21 +0200, Thomas Huth wrote:
> +    [Q_KEY_CODE_BACKSPACE] = QEMU_KEY_BACKSPACE,

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Re: [Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

[Thomas Huth]

On 12.08.2016 13:30, Gerd Hoffmann wrote:
> On Do, 2016-08-11 at 09:21 +0200, Thomas Huth wrote:
>> +    [Q_KEY_CODE_BACKSPACE] = QEMU_KEY_BACKSPACE,
> 
> Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Gerd,

thanks for your R-b! Could you take this through your ui tree? Or should
it rather go through -trivial instead?

 Thanks,
  Thomas

Re: [Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

[Gerd Hoffmann]

On Di, 2016-09-13 at 15:26 +0200, Thomas Huth wrote:
> On 12.08.2016 13:30, Gerd Hoffmann wrote:
> > On Do, 2016-08-11 at 09:21 +0200, Thomas Huth wrote:
> >> +    [Q_KEY_CODE_BACKSPACE] = QEMU_KEY_BACKSPACE,
> > 
> > Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Gerd,
> 
> thanks for your R-b! Could you take this through your ui tree? Or should
> it rather go through -trivial instead?

I was expecting it going through trivial as the qemu-trivial list was in
cc and the patch actually is trivial.  If that doesn't work out I can
pick it up for the next ui pull request.

cheers,
  Gerd

Re: [Qemu-devel] [PATCH] ui/console: Fix non-working backspace key in monitor of gtk UI

[Michael Tokarev]

Applied to -trivial, thank you!

/mjt