qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] monitor: Add an "xlate" command for translating a virtual address
Date: Mon, 15 Aug 2016 08:55:42 +1000	[thread overview]
Message-ID: <1471215342.12231.73.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAFEAcA_oQLWwiqfGKbR8Bxf0Une+GrBNo0yNJS67oyccDJaWWQ@mail.gmail.com>

On Sun, 2016-08-14 at 19:55 +0100, Peter Maydell wrote:
> On 13 August 2016 at 12:52, Benjamin Herrenschmidt
> <benh@kernel.crashing.org> wrote:
> > 
> > This is very handy when debugging a guest, especially when it's
> > stuck on accessing some HW and the only way to figure out what
> > specific piece of HW is to translate the virtual address to
> > a hardware address that can then be matched with the mtree
> > 
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> Should this wrap cpu_get_phys_page_attrs_debug() instead
> (and report the attributes to the user)?

Looking at this... the attributes are a bit of a mess aren't they ?

The requester_id is pretty much PCI specific and only useful for
load/stores coming from a device (for IOMMUs), the "secure" bit
seems to be an ARM thing and is an output from translation,
what about "user" ?

IE, it's a blend of things that are input to an access and things
that are output from translate as far as I can tell ...

For the monitor, I'm thinking of just printing "secure", what do
you think ?

Cheers,
Ben.

  parent reply	other threads:[~2016-08-14 23:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-13 11:52 [Qemu-devel] [PATCH] monitor: Add an "xlate" command for translating a virtual address Benjamin Herrenschmidt
2016-08-14 18:55 ` Peter Maydell
2016-08-14 21:24   ` Benjamin Herrenschmidt
2016-08-14 22:55   ` Benjamin Herrenschmidt [this message]
2016-08-15 10:02     ` Peter Maydell
2016-08-15 11:34       ` Benjamin Herrenschmidt
2016-08-15 11:44         ` Peter Maydell
2016-08-15 11:56           ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471215342.12231.73.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).