From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] monitor: Add an "xlate" command for translating a virtual address
Date: Mon, 15 Aug 2016 21:56:16 +1000 [thread overview]
Message-ID: <1471262176.12231.102.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAFEAcA9j2ghkdpq09doXLRTh90rAe9inzoTTBFa-pxxcuQoUQA@mail.gmail.com>
On Mon, 2016-08-15 at 12:44 +0100, Peter Maydell wrote:
> Certainly I think the QMP protocol command should just
> return all the info (I think current best-practice is
> to implement new HMP commands as wrappers round an
> equivalent QMP command). At that point we get into UI
> design questions about whether we should just print
> everything for the HMP command output, or have it default
> to just-address with an option to print with the attributes.
> I don't have a strong opinion there.
Ok I have no experience with QMP, I'll have a look, but from a UI
perspective, it's easier to not bother too much and just print it
all, something like:
translated_addr [secure=x,user=y,req_id=id]
This is low level debugging stuff, the user can cope with the verbose
output.
Ben.
prev parent reply other threads:[~2016-08-15 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 11:52 [Qemu-devel] [PATCH] monitor: Add an "xlate" command for translating a virtual address Benjamin Herrenschmidt
2016-08-14 18:55 ` Peter Maydell
2016-08-14 21:24 ` Benjamin Herrenschmidt
2016-08-14 22:55 ` Benjamin Herrenschmidt
2016-08-15 10:02 ` Peter Maydell
2016-08-15 11:34 ` Benjamin Herrenschmidt
2016-08-15 11:44 ` Peter Maydell
2016-08-15 11:56 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471262176.12231.102.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).