From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZHPR-0005Hn-Ca for qemu-devel@nongnu.org; Mon, 15 Aug 2016 08:54:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZHPL-0005ds-AX for qemu-devel@nongnu.org; Mon, 15 Aug 2016 08:54:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52002) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZHPL-0005dS-4t for qemu-devel@nongnu.org; Mon, 15 Aug 2016 08:54:23 -0400 From: Stefan Hajnoczi Date: Mon, 15 Aug 2016 13:54:16 +0100 Message-Id: <1471265656-11227-3-git-send-email-stefanha@redhat.com> In-Reply-To: <1471265656-11227-1-git-send-email-stefanha@redhat.com> References: <1471265656-11227-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] virtio: decrement vq->inuse in virtqueue_discard() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Cornelia Huck , Fam Zheng , Stefan Hajnoczi virtqueue_discard() moves vq->last_avail_idx back so the element can be popped again. It's necessary to decrement vq->inuse to avoid "leaking" the element count. Signed-off-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Reviewed-by: Cornelia Huck --- hw/virtio/virtio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 6105c6e..74c085c 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -268,6 +268,7 @@ void virtqueue_discard(VirtQueue *vq, const VirtQueueElement *elem, unsigned int len) { vq->last_avail_idx--; + vq->inuse--; virtqueue_unmap_sg(vq, elem, len); } -- 2.7.4