From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bZewj-0000gi-PG for qemu-devel@nongnu.org; Tue, 16 Aug 2016 10:02:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bZewi-0000YQ-TG for qemu-devel@nongnu.org; Tue, 16 Aug 2016 10:02:25 -0400 From: Kevin Wolf Date: Tue, 16 Aug 2016 16:02:10 +0200 Message-Id: <1471356130-9551-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] block jobs: Improve error message for missing job ID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, qemu-devel@nongnu.org If a block job is started with a node name rather than a device name and no explicit job ID is passed, it was reported that '' isn't a well-formed ID. Which is correct, but we can make the message a little bit nicer. Signed-off-by: Kevin Wolf --- blockjob.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/blockjob.c b/blockjob.c index a5ba3be..a167f96 100644 --- a/blockjob.c +++ b/blockjob.c @@ -132,6 +132,10 @@ void *block_job_create(const char *job_id, const BlockJobDriver *driver, if (job_id == NULL) { job_id = bdrv_get_device_name(bs); + if (!*job_id) { + error_setg(errp, "An explicit job ID is required for this node"); + return NULL; + } } if (!id_wellformed(job_id)) { -- 1.8.3.1