From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bamNo-0007cT-FG for qemu-devel@nongnu.org; Fri, 19 Aug 2016 12:11:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bamNh-0005xR-QI for qemu-devel@nongnu.org; Fri, 19 Aug 2016 12:10:59 -0400 Received: from mail-db5eur01on0117.outbound.protection.outlook.com ([104.47.2.117]:45622 helo=EUR01-DB5-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bamNe-0005wD-GQ for qemu-devel@nongnu.org; Fri, 19 Aug 2016 12:10:53 -0400 From: Roman Kagan Date: Fri, 19 Aug 2016 16:39:24 +0300 Message-ID: <1471613966-7267-6-git-send-email-rkagan@virtuozzo.com> In-Reply-To: <1471613966-7267-1-git-send-email-rkagan@virtuozzo.com> References: <1471613966-7267-1-git-send-email-rkagan@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH v2 5/6] virtio-balloon: drop ->stats_vq_offset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Denis V. Lunev" , Roman Kagan , "Michael S. Tsirkin" , Ladi Prosek , Stefan Hajnoczi As we don't write anything to guest on stats virtqueue we should pass len=0 to virtqueue_push(). This makes ->stats_vq_offset unnecessary, so drop it. Signed-off-by: Roman Kagan Cc: "Michael S. Tsirkin" Cc: Ladi Prosek Cc: Stefan Hajnoczi --- hw/virtio/virtio-balloon.c | 3 +-- include/hw/virtio/virtio-balloon.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index f00ad8e..056ae49 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -92,7 +92,7 @@ static void balloon_stats_push_elem(VirtIOBalloon *s) { VirtIODevice *vdev = VIRTIO_DEVICE(s); - virtqueue_push(s->svq, s->stats_vq_elem, s->stats_vq_offset); + virtqueue_push(s->svq, s->stats_vq_elem, 0); virtio_notify(vdev, s->svq); g_free(s->stats_vq_elem); s->stats_vq_elem = NULL; @@ -283,7 +283,6 @@ static void virtio_balloon_receive_stats(VirtIODevice *vdev, VirtQueue *vq) if (tag < VIRTIO_BALLOON_S_NR) s->stats[tag] = val; } - s->stats_vq_offset = offset; if (qemu_gettimeofday(&tv) < 0) { fprintf(stderr, "warning: %s: failed to get time of day\n", __func__); diff --git a/include/hw/virtio/virtio-balloon.h b/include/hw/virtio/virtio-balloon.h index d72ff7f..91b0138 100644 --- a/include/hw/virtio/virtio-balloon.h +++ b/include/hw/virtio/virtio-balloon.h @@ -38,7 +38,6 @@ typedef struct VirtIOBalloon { uint32_t actual; uint64_t stats[VIRTIO_BALLOON_S_NR]; VirtQueueElement *stats_vq_elem; - size_t stats_vq_offset; QEMUTimer *stats_timer; int64_t stats_last_update; int64_t stats_poll_interval; -- 2.7.4