From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, pbonzini@redhat.com,
mst@redhat.com, dgilbert@redhat.com, peter.maydell@linaro.org,
eblake@redhat.com, rth@twiddle.net, armbru@redhat.com,
Peter Lieven <pl@kamp.de>
Subject: [Qemu-devel] [PATCH V7 6/6] coroutine: reduce stack size to 64kB
Date: Tue, 23 Aug 2016 16:21:45 +0200 [thread overview]
Message-ID: <1471962105-31267-7-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1471962105-31267-1-git-send-email-pl@kamp.de>
evaluation with the recently introduced maximum stack usage monitoring revealed
that the actual used stack size was never above 4kB so allocating 1MB stack
for each coroutine is a lot of wasted memory. So reduce the stack size to
64kB which should still give enough head room. The guard page added
in qemu_alloc_stack will catch a potential stack overflow introduced
by this commit.
Signed-off-by: Peter Lieven <pl@kamp.de>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
include/qemu/coroutine_int.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/coroutine_int.h b/include/qemu/coroutine_int.h
index f62f83f..011910f 100644
--- a/include/qemu/coroutine_int.h
+++ b/include/qemu/coroutine_int.h
@@ -28,7 +28,7 @@
#include "qemu/queue.h"
#include "qemu/coroutine.h"
-#define COROUTINE_STACK_SIZE (1 << 20)
+#define COROUTINE_STACK_SIZE (1 << 16)
typedef enum {
COROUTINE_YIELD = 1,
--
1.9.1
next prev parent reply other threads:[~2016-08-23 14:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 14:21 [Qemu-devel] [PATCH V7 0/6] coroutine: mmap stack memory and stack size Peter Lieven
2016-08-23 14:21 ` [Qemu-devel] [PATCH V7 1/6] oslib-posix: add helpers for stack alloc and free Peter Lieven
2016-08-23 14:58 ` Richard Henderson
2016-08-23 14:21 ` [Qemu-devel] [PATCH V7 2/6] coroutine: add a macro for the coroutine stack size Peter Lieven
2016-08-23 14:21 ` [Qemu-devel] [PATCH V7 3/6] coroutine-ucontext: use helper for allocating stack memory Peter Lieven
2016-08-23 14:21 ` [Qemu-devel] [PATCH V7 4/6] coroutine-sigaltstack: " Peter Lieven
2016-08-23 14:21 ` [Qemu-devel] [PATCH V7 5/6] oslib-posix: add a configure switch to debug stack usage Peter Lieven
2016-08-23 14:21 ` Peter Lieven [this message]
2016-08-30 12:08 ` [Qemu-devel] [PATCH V7 0/6] coroutine: mmap stack memory and stack size Paolo Bonzini
2016-08-31 14:31 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471962105-31267-7-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).