From: Sascha Silbe <silbe@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org, Fam Zheng <famz@redhat.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: [Qemu-devel] [PATCH v2 2/7] docker: avoid dependency on 'realpath' package
Date: Wed, 24 Aug 2016 20:30:58 +0200 [thread overview]
Message-ID: <1472063464-790-3-git-send-email-silbe@linux.vnet.ibm.com> (raw)
In-Reply-To: <1472063464-790-1-git-send-email-silbe@linux.vnet.ibm.com>
The 'realpath' executable is shipped in a separate package that isn't
installed by default on some distros.
We already use 'readlink -e' (provided by GNU coreutils) in some other
part of the code, so let's settle for that instead.
Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
---
Too bad there isn't a POSIX equivalent of this.
tests/docker/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index 4f4707d..1b20db0 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -116,7 +116,7 @@ docker-run-%: docker-qemu-src
-e EXTRA_CONFIGURE_OPTS=$(EXTRA_CONFIGURE_OPTS) \
-e V=$V -e J=$J -e DEBUG=$(DEBUG)\
-e CCACHE_DIR=/var/tmp/ccache \
- -v $$(realpath $(DOCKER_SRC_COPY)):/var/tmp/qemu:z$(COMMA)ro \
+ -v $$(readlink -e $(DOCKER_SRC_COPY)):/var/tmp/qemu:z$(COMMA)ro \
-v $(DOCKER_CCACHE_DIR):/var/tmp/ccache:z \
qemu:$(IMAGE) \
/var/tmp/qemu/run \
--
1.9.1
next prev parent reply other threads:[~2016-08-24 18:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 18:30 [Qemu-devel] [PATCH v2 0/7] docker tests fixes Sascha Silbe
2016-08-24 18:30 ` [Qemu-devel] [PATCH v2 1/7] docker.py: don't hang on large docker output Sascha Silbe
2016-09-06 1:30 ` Fam Zheng
2016-09-06 18:31 ` Sascha Silbe
2016-09-07 1:53 ` Fam Zheng
2016-09-07 1:59 ` Eric Blake
2016-08-24 18:30 ` Sascha Silbe [this message]
2016-08-24 18:30 ` [Qemu-devel] [PATCH v2 3/7] docker: debian-bootstrap.pre: print helpful message if DEB_ARCH/DEB_TYPE unset Sascha Silbe
2016-09-06 1:47 ` Fam Zheng
2016-09-06 18:45 ` Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 4/7] docker: print warning if EXECUTABLE is not set when building debootstrap image Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 5/7] docker: make sure debootstrap is at least 1.0.67 Sascha Silbe
2016-09-06 1:43 ` Fam Zheng
2016-09-06 18:54 ` Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 6/7] docker: build debootstrap after cloning Sascha Silbe
2016-08-24 18:31 ` [Qemu-devel] [PATCH v2 7/7] docker: silence debootstrap when --quiet is given Sascha Silbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472063464-790-3-git-send-email-silbe@linux.vnet.ibm.com \
--to=silbe@linux.vnet.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).