From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdPvR-0007GE-La for qemu-devel@nongnu.org; Fri, 26 Aug 2016 18:48:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdPvM-00036m-O8 for qemu-devel@nongnu.org; Fri, 26 Aug 2016 18:48:37 -0400 Message-ID: <1472251690.2889.69.camel@kernel.crashing.org> From: Benjamin Herrenschmidt Date: Sat, 27 Aug 2016 08:48:10 +1000 In-Reply-To: <0bfc38b7-e4a6-17a8-1ab2-485e45b09eda@kaod.org> References: <1470388537-2908-1-git-send-email-clg@kaod.org> <1470388537-2908-2-git-send-email-clg@kaod.org> <20160816021235.GA2478@voom.fritz.box> <0bfc38b7-e4a6-17a8-1ab2-485e45b09eda@kaod.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?C=E9dric?= Le Goater , David Gibson Cc: qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org On Fri, 2016-08-26 at 16:47 +0200, C=C3=A9dric Le Goater wrote: > >> +static void powernv_machine_class_init(ObjectClass *oc, void > *data) > >> +{ > >> +=C2=A0=C2=A0=C2=A0 MachineClass *mc =3D MACHINE_CLASS(oc); > >> + > >> +=C2=A0=C2=A0=C2=A0 mc->init =3D ppc_powernv_init; > >> +=C2=A0=C2=A0=C2=A0 mc->reset =3D ppc_powernv_reset; > >> +=C2=A0=C2=A0=C2=A0 mc->block_default_type =3D IF_IDE; > >=C2=A0 > > IDE?=C2=A0 Really? >=20 > nah :) It's SCSI again now. >=20 > I was trying to reconcile all the little hunks in the different=C2=A0 > patches of Ben. IF_IDE was introduced at the end of the patchset.=C2=A0 > I suppose that adding a ISA bus to PowerNV had some influence :) It's meant to be IF_IDE, the default interface is AHCI. Cheers, Ben.