From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: "Cédric Le Goater" <clg@kaod.org>,
qemu-ppc@nongnu.org, "Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object
Date: Wed, 31 Aug 2016 11:06:53 +1000 [thread overview]
Message-ID: <1472605613.2388.73.camel@kernel.crashing.org> (raw)
In-Reply-To: <20160830062820.GB1753@littlecatz>
On Tue, 2016-08-30 at 02:28 -0400, David Gibson wrote:
> No.. the PIR itself is a cpu level construct (and we already have a
> place for that in the cpu state). The DT id as such isn't, although
> it happens to have the same value. The fact it has the same value is
> itself a machine type property.
>
> [Aside: removing dt_id from the cpu will require disentangling it from
> the kvm vcpu id]
On P8 and P9 the PIR of a thread is a chip property, as it encodes
the HW node, chip, core and thread ID (hint: it's not 0 based on P8,
well the core isn't).
So it has to match accordingly for things like core XSCOMs which we
want to start supporting some of.
It also has to match what's in the device-tree as a pretty standard
requirement of all powerpc device-trees.
Finally it also happen to be the target interrupt server on all known
implementations.
Cheers,
Ben.
next prev parent reply other threads:[~2016-08-31 1:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 9:15 [Qemu-devel] [PATCH 0/3] ppc/pnc: add a minimal platform Cédric Le Goater
2016-08-05 9:15 ` [Qemu-devel] [PATCH 1/3] ppc/pnv: add skeleton PowerNV platform Cédric Le Goater
2016-08-16 2:12 ` David Gibson
2016-08-26 14:47 ` Cédric Le Goater
2016-08-26 22:48 ` Benjamin Herrenschmidt
2016-08-29 14:17 ` David Gibson
2016-08-29 14:16 ` David Gibson
2016-08-05 9:15 ` [Qemu-devel] [PATCH 2/3] ppc/pnv: add a PnvChip object Cédric Le Goater
2016-08-05 9:44 ` Benjamin Herrenschmidt
2016-08-05 16:48 ` Cédric Le Goater
2016-08-05 22:43 ` Benjamin Herrenschmidt
2016-08-16 2:18 ` David Gibson
2016-08-16 2:21 ` David Gibson
2016-08-26 16:31 ` Cédric Le Goater
2016-08-05 9:15 ` [Qemu-devel] [PATCH 3/3] ppc/pnv: add a PowerNVCPUCore object Cédric Le Goater
2016-08-16 2:39 ` David Gibson
2016-08-16 5:02 ` Benjamin Herrenschmidt
2016-08-26 17:55 ` Cédric Le Goater
2016-08-26 17:49 ` Cédric Le Goater
2016-08-29 14:30 ` David Gibson
2016-08-30 6:15 ` Benjamin Herrenschmidt
2016-08-30 6:28 ` David Gibson
2016-08-31 1:06 ` Benjamin Herrenschmidt [this message]
2016-08-30 7:23 ` Cédric Le Goater
2016-09-05 1:45 ` David Gibson
2016-09-06 7:45 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472605613.2388.73.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).