qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: qemu-ppc@nongnu.org
Cc: David Gibson <david@gibson.dropbear.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
	Cedric Le Goater <clg@kaod.org>
Subject: [Qemu-devel] [PATCH v2 7/7] monitor: fix crash for platforms without a CPU 0
Date: Wed, 31 Aug 2016 18:34:15 +0200	[thread overview]
Message-ID: <1472661255-20160-8-git-send-email-clg@kaod.org> (raw)
In-Reply-To: <1472661255-20160-1-git-send-email-clg@kaod.org>

On PowerNV, CPU ids start at 0x8 or 0x20, we don't have a CPU 0
anymore. So let's use the first_cpu index to initialize the monitor.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---

 So that you can dump the cpu list with the monitor :

	(qemu) info cpus
	* CPU #8: nip=0x0000000000000010 thread_id=7742
	  CPU #16: nip=0x0000000000000010 thread_id=7740
	  CPU #24: nip=0x0000000000000010 thread_id=7740
	  CPU #32: nip=0x0000000000000010 thread_id=7740
	  CPU #40: nip=0x0000000000000010 thread_id=7740
	  CPU #48: nip=0x0000000000000010 thread_id=7740
	  CPU #72: nip=0x0000000000000010 thread_id=7740
	  CPU #80: nip=0x0000000000000010 thread_id=7740
	  CPU #136: nip=0x0000000000000010 thread_id=7740
	  CPU #144: nip=0x0000000000000010 thread_id=7740
	  CPU #152: nip=0x0000000000000010 thread_id=7740
	  CPU #160: nip=0x0000000000000010 thread_id=7740
	  CPU #168: nip=0x0000000000000010 thread_id=7740
	  CPU #176: nip=0x0000000000000010 thread_id=7740
	  CPU #200: nip=0x0000000000000010 thread_id=7740
	  CPU #208: nip=0x0000000000000010 thread_id=7740

 monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor.c b/monitor.c
index e9009de09a6c..19b8ec14f40e 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1027,7 +1027,7 @@ int monitor_set_cpu(int cpu_index)
 CPUState *mon_get_cpu(void)
 {
     if (!cur_mon->mon_cpu) {
-        monitor_set_cpu(0);
+        monitor_set_cpu(first_cpu->cpu_index);
     }
     cpu_synchronize_state(cur_mon->mon_cpu);
     return cur_mon->mon_cpu;
-- 
2.7.4

  parent reply	other threads:[~2016-08-31 16:36 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 16:34 [Qemu-devel] [PATCH v2 0/7] ppc/pnv: add a minimal platform Cédric Le Goater
2016-08-31 16:34 ` [Qemu-devel] [PATCH v2 1/7] ppc/pnv: add skeleton PowerNV platform Cédric Le Goater
2016-09-01 16:31   ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2016-09-02  6:32     ` Cédric Le Goater
2016-09-02  6:39       ` Benjamin Herrenschmidt
2016-09-05  2:48   ` [Qemu-devel] " David Gibson
2016-09-05  6:06     ` Cédric Le Goater
2016-08-31 16:34 ` [Qemu-devel] [PATCH v2 2/7] ppc/pnv: add a PnvChip object Cédric Le Goater
2016-09-01 17:21   ` [Qemu-devel] [Qemu-ppc] " Greg Kurz
2016-09-02  6:34     ` Cédric Le Goater
2016-09-05  2:58   ` [Qemu-devel] " David Gibson
2016-09-05  6:59     ` Benjamin Herrenschmidt
2016-09-05  7:41       ` Cédric Le Goater
2016-09-05  8:28         ` Benjamin Herrenschmidt
2016-09-06  0:49           ` David Gibson
2016-09-06  6:21             ` Cédric Le Goater
2016-09-05  7:41       ` David Gibson
2016-09-05  9:10         ` Cédric Le Goater
2016-09-06  0:50           ` David Gibson
2016-09-05  7:56     ` Cédric Le Goater
2016-09-06  0:52       ` David Gibson
2016-08-31 16:34 ` [Qemu-devel] [PATCH v2 3/7] ppc/pnv: Add XSCOM infrastructure Cédric Le Goater
2016-09-05  3:39   ` David Gibson
2016-09-05  7:11     ` Benjamin Herrenschmidt
2016-09-06  0:48       ` David Gibson
2016-09-06 14:42         ` Cédric Le Goater
2016-09-06 21:47           ` Benjamin Herrenschmidt
2016-09-06 21:49             ` Benjamin Herrenschmidt
2016-09-07 15:55               ` Cédric Le Goater
2016-09-07 19:48                 ` Benjamin Herrenschmidt
2016-09-07  2:03             ` David Gibson
2016-09-07 15:47             ` Cédric Le Goater
2016-09-07 21:53               ` Benjamin Herrenschmidt
2016-09-08  8:52                 ` Cédric Le Goater
2016-09-07  2:01           ` David Gibson
2016-09-06 14:42     ` Cédric Le Goater
2016-09-06 21:45       ` Benjamin Herrenschmidt
2016-09-07  2:02         ` David Gibson
2016-09-07 16:40         ` Cédric Le Goater
2016-09-07  1:59       ` David Gibson
2016-09-07  5:27         ` Benjamin Herrenschmidt
2016-09-07  5:46           ` David Gibson
2016-09-07  8:29             ` Benjamin Herrenschmidt
2016-09-05  4:16   ` [Qemu-devel] [Qemu-ppc] " Sam Bobroff
2016-09-06 14:51     ` Cédric Le Goater
2016-08-31 16:34 ` [Qemu-devel] [PATCH v2 4/7] ppc/pnv: add a core mask to PnvChip Cédric Le Goater
2016-09-02  8:03   ` Cédric Le Goater
2016-09-05  3:42   ` David Gibson
2016-09-05 11:13     ` Cédric Le Goater
2016-09-05 11:30       ` Benjamin Herrenschmidt
2016-08-31 16:34 ` [Qemu-devel] [PATCH v2 5/7] ppc/pnv: add a PnvCore object Cédric Le Goater
2016-09-05  4:02   ` David Gibson
2016-09-06  6:14     ` Cédric Le Goater
2016-09-07  1:48       ` David Gibson
2016-08-31 16:34 ` [Qemu-devel] [PATCH v2 6/7] ppc/pnv: add a XScomDevice to PnvCore Cédric Le Goater
2016-09-05  4:19   ` David Gibson
2016-09-06 13:54     ` Cédric Le Goater
2016-09-07  1:51       ` David Gibson
2016-08-31 16:34 ` Cédric Le Goater [this message]
2016-09-05  4:27   ` [Qemu-devel] [PATCH v2 7/7] monitor: fix crash for platforms without a CPU 0 David Gibson
2016-09-06  6:28     ` Cédric Le Goater
2016-09-07  1:49       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472661255-20160-8-git-send-email-clg@kaod.org \
    --to=clg@kaod.org \
    --cc=agraf@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).