From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfi2l-0000tB-7y for qemu-devel@nongnu.org; Fri, 02 Sep 2016 02:33:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bfi2c-0002uX-On for qemu-devel@nongnu.org; Fri, 02 Sep 2016 02:33:38 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:38098 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bfi2c-0002uJ-Ik for qemu-devel@nongnu.org; Fri, 02 Sep 2016 02:33:30 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u826Mva0012539 for ; Fri, 2 Sep 2016 02:33:28 -0400 Received: from e23smtp03.au.ibm.com (e23smtp03.au.ibm.com [202.81.31.145]) by mx0b-001b2d01.pphosted.com with ESMTP id 2569eehx11-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 02 Sep 2016 02:33:28 -0400 Received: from localhost by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 2 Sep 2016 16:33:25 +1000 From: Nikunj A Dadhania Date: Fri, 2 Sep 2016 12:02:53 +0530 In-Reply-To: <1472797976-24210-1-git-send-email-nikunj@linux.vnet.ibm.com> References: <1472797976-24210-1-git-send-email-nikunj@linux.vnet.ibm.com> Message-Id: <1472797976-24210-2-git-send-email-nikunj@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH RFC 1/4] spapr-hcall: take iothread lock during handler call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-ppc@nongnu.org, alex.bennee@linaro.org, david@gibson.dropbear.id.au, rth@twiddle.net Cc: qemu-devel@nongnu.org, nikunj@linux.vnet.ibm.com, benh@kernel.crashing.org Signed-off-by: Nikunj A Dadhania --- hw/ppc/spapr_hcall.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index e5eca67..daea7a0 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -1075,20 +1075,27 @@ target_ulong spapr_hypercall(PowerPCCPU *cpu, target_ulong opcode, target_ulong *args) { sPAPRMachineState *spapr = SPAPR_MACHINE(qdev_get_machine()); + target_ulong ret; if ((opcode <= MAX_HCALL_OPCODE) && ((opcode & 0x3) == 0)) { spapr_hcall_fn fn = papr_hypercall_table[opcode / 4]; if (fn) { - return fn(cpu, spapr, opcode, args); + qemu_mutex_lock_iothread(); + ret = fn(cpu, spapr, opcode, args); + qemu_mutex_unlock_iothread(); + return ret; } } else if ((opcode >= KVMPPC_HCALL_BASE) && (opcode <= KVMPPC_HCALL_MAX)) { spapr_hcall_fn fn = kvmppc_hypercall_table[opcode - KVMPPC_HCALL_BASE]; if (fn) { - return fn(cpu, spapr, opcode, args); + qemu_mutex_lock_iothread(); + ret = fn(cpu, spapr, opcode, args); + qemu_mutex_unlock_iothread(); + return ret; } } -- 2.7.4