From: Rabin Vincent <rabin.vincent@axis.com>
To: edgar.iglesias@gmail.com
Cc: qemu-devel@nongnu.org, "Edgar E. Iglesias" <edgar@axis.com>,
Rabin Vincent <rabinv@axis.com>
Subject: [Qemu-devel] [PATCH 5/9] target-cris: sync CC state at load/stores.
Date: Mon, 5 Sep 2016 13:54:08 +0200 [thread overview]
Message-ID: <1473076452-19795-5-git-send-email-rabin.vincent@axis.com> (raw)
In-Reply-To: <1473076452-19795-1-git-send-email-rabin.vincent@axis.com>
From: "Edgar E. Iglesias" <edgar@axis.com>
Icount may choose to abort and recompile a TB at any load/store. We
need to sync the CC state at these insns.
Signed-off-by: Edgar E. Iglesias <edgar@axis.com>
Signed-off-by: Rabin Vincent <rabinv@axis.com>
---
target-cris/translate.c | 9 +++++++++
target-cris/translate_v10.c | 3 +++
2 files changed, 12 insertions(+)
diff --git a/target-cris/translate.c b/target-cris/translate.c
index f4a8d7d..c280e24 100644
--- a/target-cris/translate.c
+++ b/target-cris/translate.c
@@ -1098,6 +1098,9 @@ static void gen_load64(DisasContext *dc, TCGv_i64 dst, TCGv addr)
{
int mem_index = cpu_mmu_index(&dc->cpu->env, false);
+ /* Due to icount, we need to update the CC flags on load/stores. */
+ cris_evaluate_flags(dc);
+
/* If we get a fault on a delayslot we must keep the jmp state in
the cpu-state to be able to re-execute the jmp. */
if (dc->delayed_branch == 1) {
@@ -1112,6 +1115,9 @@ static void gen_load(DisasContext *dc, TCGv dst, TCGv addr,
{
int mem_index = cpu_mmu_index(&dc->cpu->env, false);
+ /* Due to icount, we need to update the CC flags on load/stores. */
+ cris_evaluate_flags(dc);
+
/* If we get a fault on a delayslot we must keep the jmp state in
the cpu-state to be able to re-execute the jmp. */
if (dc->delayed_branch == 1) {
@@ -1127,6 +1133,9 @@ static void gen_store (DisasContext *dc, TCGv addr, TCGv val,
{
int mem_index = cpu_mmu_index(&dc->cpu->env, false);
+ /* Due to icount, we need to update the CC flags on load/stores. */
+ cris_evaluate_flags(dc);
+
/* If we get a fault on a delayslot we must keep the jmp state in
the cpu-state to be able to re-execute the jmp. */
if (dc->delayed_branch == 1) {
diff --git a/target-cris/translate_v10.c b/target-cris/translate_v10.c
index 4707a18..a3da425 100644
--- a/target-cris/translate_v10.c
+++ b/target-cris/translate_v10.c
@@ -99,6 +99,9 @@ static void gen_store_v10(DisasContext *dc, TCGv addr, TCGv val,
{
int mem_index = cpu_mmu_index(&dc->cpu->env, false);
+ /* Due to icount, we need to update the CC flags on load/stores. */
+ cris_evaluate_flags(dc);
+
/* If we get a fault on a delayslot we must keep the jmp state in
the cpu-state to be able to re-execute the jmp. */
if (dc->delayed_branch == 1) {
--
2.1.4
next prev parent reply other threads:[~2016-09-05 11:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 11:54 [Qemu-devel] [PATCH 1/9] tests: cris: force inlining Rabin Vincent
2016-09-05 11:54 ` [Qemu-devel] [PATCH 2/9] tests: cris: fix syscall inline asm Rabin Vincent
2016-09-05 18:20 ` Richard Henderson
2016-09-08 11:38 ` [Qemu-devel] [PATCHv2 2/8] " Rabin Vincent
2016-09-08 16:10 ` Richard Henderson
2016-09-05 11:54 ` [Qemu-devel] [PATCH 3/9] tests: cris: remove openpf4 test Rabin Vincent
2016-09-12 22:51 ` Edgar E. Iglesias
2016-09-05 11:54 ` [Qemu-devel] [PATCH 4/9] tests: cris: remove check_time1 Rabin Vincent
2016-09-12 23:00 ` Edgar E. Iglesias
2016-09-05 11:54 ` Rabin Vincent [this message]
2016-09-05 19:02 ` [Qemu-devel] [PATCH 5/9] target-cris: sync CC state at load/stores Richard Henderson
2016-09-06 21:52 ` Edgar E. Iglesias
2016-09-05 11:54 ` [Qemu-devel] [PATCH 6/9] target-cris: reduce v32isms from v10 log dumps Rabin Vincent
2016-09-12 22:59 ` Edgar E. Iglesias
2016-09-14 12:48 ` Hans-Peter Nilsson
2016-09-26 7:06 ` Rabin Vincent
2016-09-05 11:54 ` [Qemu-devel] [PATCH 7/9] target-cris: ignore prefix insns in singlestep Rabin Vincent
2016-09-12 22:49 ` Edgar E. Iglesias
2016-09-14 13:32 ` Hans-Peter Nilsson
2016-09-05 11:54 ` [Qemu-devel] [PATCH 8/9] target-cris: add v17 CPU Rabin Vincent
2016-09-12 22:18 ` Edgar E. Iglesias
2016-09-26 7:17 ` Rabin Vincent
2016-09-28 10:42 ` Edgar E. Iglesias
2016-09-30 16:50 ` Rabin Vincent
2016-09-05 11:54 ` [Qemu-devel] [PATCH 9/9] tests: cris: add v17 ADDC test Rabin Vincent
2016-09-12 23:16 ` Edgar E. Iglesias
2016-09-06 21:53 ` [Qemu-devel] [PATCH 1/9] tests: cris: force inlining Edgar E. Iglesias
2016-09-08 11:41 ` Rabin Vincent
2016-09-08 18:06 ` Peter Maydell
2016-09-08 18:21 ` Eric Blake
2016-09-12 9:43 ` [Qemu-devel] [PATCHv2 1/8] " Rabin Vincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473076452-19795-5-git-send-email-rabin.vincent@axis.com \
--to=rabin.vincent@axis.com \
--cc=edgar.iglesias@gmail.com \
--cc=edgar@axis.com \
--cc=qemu-devel@nongnu.org \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).