* [Qemu-devel] [PATCH] ipmi: fix build config variable name for ipmi_bmc_extern.o
@ 2016-09-05 17:21 Daniel P. Berrange
2016-09-08 19:45 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrange @ 2016-09-05 17:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Corey Minyard, Daniel P. Berrange
The original commit:
commit 67aa56fc03bea44ccf384ea400515a8a58844a50
Author: Corey Minyard <cminyard@mvista.com>
Date: Thu Dec 17 12:50:06 2015 -0600
ipmi: Add an external connection simulation interface
defined a new variable CONFIG_IPMI_EXTERN, but then went
on to mistakely use the pre-existing CONFIG_IPMI_LOCAL
variable.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
hw/ipmi/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ipmi/Makefile.objs b/hw/ipmi/Makefile.objs
index a90318d..1b422bb 100644
--- a/hw/ipmi/Makefile.objs
+++ b/hw/ipmi/Makefile.objs
@@ -1,5 +1,5 @@
common-obj-$(CONFIG_IPMI) += ipmi.o
common-obj-$(CONFIG_IPMI_LOCAL) += ipmi_bmc_sim.o
-common-obj-$(CONFIG_IPMI_LOCAL) += ipmi_bmc_extern.o
+common-obj-$(CONFIG_IPMI_EXTERN) += ipmi_bmc_extern.o
common-obj-$(CONFIG_ISA_IPMI_KCS) += isa_ipmi_kcs.o
common-obj-$(CONFIG_ISA_IPMI_BT) += isa_ipmi_bt.o
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] ipmi: fix build config variable name for ipmi_bmc_extern.o
2016-09-05 17:21 [Qemu-devel] [PATCH] ipmi: fix build config variable name for ipmi_bmc_extern.o Daniel P. Berrange
@ 2016-09-08 19:45 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2016-09-08 19:45 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel; +Cc: qemu-trivial
On 09/05/2016 12:21 PM, Daniel P. Berrange wrote:
> The original commit:
>
> commit 67aa56fc03bea44ccf384ea400515a8a58844a50
> Author: Corey Minyard <cminyard@mvista.com>
> Date: Thu Dec 17 12:50:06 2015 -0600
>
> ipmi: Add an external connection simulation interface
>
> defined a new variable CONFIG_IPMI_EXTERN, but then went
> on to mistakely use the pre-existing CONFIG_IPMI_LOCAL
> variable.
Thanks, this is queued and I'll submit
-corey
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> hw/ipmi/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/ipmi/Makefile.objs b/hw/ipmi/Makefile.objs
> index a90318d..1b422bb 100644
> --- a/hw/ipmi/Makefile.objs
> +++ b/hw/ipmi/Makefile.objs
> @@ -1,5 +1,5 @@
> common-obj-$(CONFIG_IPMI) += ipmi.o
> common-obj-$(CONFIG_IPMI_LOCAL) += ipmi_bmc_sim.o
> -common-obj-$(CONFIG_IPMI_LOCAL) += ipmi_bmc_extern.o
> +common-obj-$(CONFIG_IPMI_EXTERN) += ipmi_bmc_extern.o
> common-obj-$(CONFIG_ISA_IPMI_KCS) += isa_ipmi_kcs.o
> common-obj-$(CONFIG_ISA_IPMI_BT) += isa_ipmi_bt.o
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-08 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-05 17:21 [Qemu-devel] [PATCH] ipmi: fix build config variable name for ipmi_bmc_extern.o Daniel P. Berrange
2016-09-08 19:45 ` Corey Minyard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).