From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGMx-00027b-UZ for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:24:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhGMr-0004zD-P6 for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:24:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhGMr-0004yt-JG for qemu-devel@nongnu.org; Tue, 06 Sep 2016 09:24:49 -0400 From: Peter Xu Date: Tue, 6 Sep 2016 21:24:27 +0800 Message-Id: <1473168267-25673-4-git-send-email-peterx@redhat.com> In-Reply-To: <1473168267-25673-1-git-send-email-peterx@redhat.com> References: <1473168267-25673-1-git-send-email-peterx@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/3] intel_iommu: allow invalidation typed notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: dgibson@redhat.com, jasowang@redhat.com, mst@redhat.com, pbonzini@redhat.com, cornelia.huck@de.ibm.com, wexu@redhat.com, vkaplans@redhat.com, alex.williamson@redhat.com, peterx@redhat.com Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. Before that is achieved, let's open a door for vhost DMAR support, which only requires device-IOTLB based cache invalidations. Meanwhile, converting hw_error() to error_report() and exit(), to make the error messages clean and obvious (so no CPU registers will be dumped). Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index c6bd8f6..227c931 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -1978,10 +1978,14 @@ static void vtd_iommu_notifier_add(MemoryRegion *iommu, IOMMUNotifier *n) { VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu); - hw_error("Device at bus %s addr %02x.%d requires iommu notifier which " - "is currently not supported by intel-iommu emulation", - vtd_as->bus->qbus.name, PCI_SLOT(vtd_as->devfn), - PCI_FUNC(vtd_as->devfn)); + if (n->notifier_caps & IOMMU_NOTIFIER_CHANGE) { + error_report("Device at bus %s addr %02x.%d requires iommu " + "notifier which is currently not supported by " + "intel-iommu emulation", + vtd_as->bus->qbus.name, PCI_SLOT(vtd_as->devfn), + PCI_FUNC(vtd_as->devfn)); + exit(1); + } } static const VMStateDescription vtd_vmstate = { -- 2.7.4