From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIy3-00078O-6f for qemu-devel@nongnu.org; Tue, 06 Sep 2016 12:11:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhIy2-00077z-1M for qemu-devel@nongnu.org; Tue, 06 Sep 2016 12:11:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhIy1-00077o-Pe for qemu-devel@nongnu.org; Tue, 06 Sep 2016 12:11:21 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 72F1D80086 for ; Tue, 6 Sep 2016 16:11:21 +0000 (UTC) From: Maxime Coquelin Date: Tue, 6 Sep 2016 18:11:09 +0200 Message-Id: <1473178269-16718-5-git-send-email-maxime.coquelin@redhat.com> In-Reply-To: <1473178269-16718-1-git-send-email-maxime.coquelin@redhat.com> References: <1473178269-16718-1-git-send-email-maxime.coquelin@redhat.com> Subject: [Qemu-devel] [RFC 4/4] virtio-net: Add MTU feature support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mst@redhat.com, qemu-devel@nongnu.org Cc: jasowang@redhat.com, Maxime Coquelin , Aaron Conole If negociated, virtio-net gets the advised MTU from vhost-net, and provides it to the guest through a new virtio_net_config entry. Cc: Michael S. Tsirkin Cc: Aaron Conole --- hw/net/virtio-net.c | 16 ++++++++++++++++ include/hw/virtio/virtio-net.h | 1 + 2 files changed, 17 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 01f1351..0974d87 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -50,6 +50,8 @@ static VirtIOFeature feature_sizes[] = { .end = endof(struct virtio_net_config, status)}, {.flags = 1 << VIRTIO_NET_F_MQ, .end = endof(struct virtio_net_config, max_virtqueue_pairs)}, + {.flags = 1 << VIRTIO_NET_F_MTU, + .end = endof(struct virtio_net_config, mtu)}, {} }; @@ -74,6 +76,10 @@ static void virtio_net_get_config(VirtIODevice *vdev, uint8_t *config) VirtIONet *n = VIRTIO_NET(vdev); struct virtio_net_config netcfg; + if (virtio_vdev_has_feature(vdev, VIRTIO_NET_F_MTU)) { + virtio_stw_p(vdev, &netcfg.mtu, n->mtu); + } + virtio_stw_p(vdev, &netcfg.status, n->status); virtio_stw_p(vdev, &netcfg.max_virtqueue_pairs, n->max_queues); memcpy(netcfg.mac, n->mac, ETH_ALEN); @@ -526,6 +532,7 @@ static uint64_t virtio_net_get_features(VirtIODevice *vdev, uint64_t features, features |= n->host_features; virtio_add_feature(&features, VIRTIO_NET_F_MAC); + virtio_add_feature(&features, VIRTIO_NET_F_MTU); if (!peer_has_vnet_hdr(n)) { virtio_clear_feature(&features, VIRTIO_NET_F_CSUM); @@ -627,6 +634,14 @@ static void virtio_net_set_features(VirtIODevice *vdev, uint64_t features) } else { memset(n->vlans, 0xff, MAX_VLAN >> 3); } + + if (virtio_has_feature(features, VIRTIO_NET_F_MTU)) { + NetClientState *nc = qemu_get_queue(n->nic); + + if (get_vhost_net(nc->peer)) { + n->mtu = vhost_net_get_mtu(get_vhost_net(nc->peer)); + } + } } static int virtio_net_handle_rx_mode(VirtIONet *n, uint8_t cmd, @@ -1688,6 +1703,7 @@ static void virtio_net_set_config_size(VirtIONet *n, uint64_t host_features) { int i, config_size = 0; virtio_add_feature(&host_features, VIRTIO_NET_F_MAC); + virtio_add_feature(&host_features, VIRTIO_NET_F_MTU); for (i = 0; feature_sizes[i].flags != 0; i++) { if (host_features & feature_sizes[i].flags) { config_size = MAX(feature_sizes[i].end, config_size); diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h index 91ed97c..13b2a8d 100644 --- a/include/hw/virtio/virtio-net.h +++ b/include/hw/virtio/virtio-net.h @@ -95,6 +95,7 @@ typedef struct VirtIONet { QEMUTimer *announce_timer; int announce_counter; bool needs_vnet_hdr_swap; + uint16_t mtu; } VirtIONet; void virtio_net_set_netclient_name(VirtIONet *n, const char *name, -- 2.7.4