From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] console: skip same-size resize
Date: Wed, 07 Sep 2016 13:10:13 +0200 [thread overview]
Message-ID: <1473246613.28663.54.camel@redhat.com> (raw)
In-Reply-To: <20160826094711.14470-1-marcandre.lureau@redhat.com>
On Fr, 2016-08-26 at 13:47 +0400, Marc-André Lureau wrote:
> virtio-gpu does a set-scanout at each frame (it might be a driver
> regression).
xorg vs wayland maybe? as far I know only wayland pageflips for each
frame.
> qemu_console_resize() recreate a surface even if the size
> didn't change, and this shows up in profiling reports because the
> surface is cleared. With this patch, I get a +15-20% glmark2
> improvement.
Does anything break if you simply drop the qemu_console_resize() call
from virgl_cmd_set_scanout? In theory we should not need a surface in
the first place in scanout mode, but I suspect there is a reason why the
call is there ...
cheers,
Gerd
next prev parent reply other threads:[~2016-09-07 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 9:47 [Qemu-devel] [PATCH] console: skip same-size resize Marc-André Lureau
2016-09-07 11:10 ` Gerd Hoffmann [this message]
2016-09-07 13:00 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473246613.28663.54.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).