From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42502)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bhakI-00012W-AX
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 07:10:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bhakC-0004Hr-5h
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 07:10:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48116)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1bhakC-0004Hl-0N
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 07:10:16 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 99A4681F07
	for <qemu-devel@nongnu.org>; Wed,  7 Sep 2016 11:10:15 +0000 (UTC)
Message-ID: <1473246613.28663.54.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 07 Sep 2016 13:10:13 +0200
In-Reply-To: <20160826094711.14470-1-marcandre.lureau@redhat.com>
References: <20160826094711.14470-1-marcandre.lureau@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] console: skip same-size resize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>
Cc: qemu-devel@nongnu.org

On Fr, 2016-08-26 at 13:47 +0400, Marc-Andr=C3=A9 Lureau wrote:
> virtio-gpu does a set-scanout at each frame (it might be a driver
> regression).

xorg vs wayland maybe?  as far I know only wayland pageflips for each
frame.

> qemu_console_resize() recreate a surface even if the size
> didn't change, and this shows up in profiling reports because the
> surface is cleared. With this patch, I get a +15-20% glmark2
> improvement.

Does anything break if you simply drop the qemu_console_resize() call
from virgl_cmd_set_scanout?  In theory we should not need a surface in
the first place in scanout mode, but I suspect there is a reason why the
call is there ...

cheers,
  Gerd