From: Gerd Hoffmann <kraxel@redhat.com>
To: Andrei Karas <akaras@inbox.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM.
Date: Wed, 07 Sep 2016 13:29:31 +0200 [thread overview]
Message-ID: <1473247771.28663.63.camel@redhat.com> (raw)
In-Reply-To: <1471984640.899954839@f422.i.mail.ru>
On Di, 2016-08-23 at 23:37 +0300, Andrei Karas wrote:
> Signed-off-by: Andrei Karas <akaras@inbox.ru>
> ---
> ui/sdl2.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index 4441e99..9523f64 100644
> --- a/ui/sdl2.c
> +++ b/ui/sdl2.c
> @@ -584,9 +584,6 @@ static void handle_windowevent(SDL_Event *ev)
> }
> break;
> case SDL_WINDOWEVENT_HIDDEN:
> - if (!scon->hidden) {
> - SDL_ShowWindow(scon->real_window);
> - }
Ok, but we should update scon->hidden with the new state then I guess?
And probably also in case the DE/WM shows the window again?
cheers,
Gerd
next prev parent reply other threads:[~2016-09-07 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 20:37 [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM Andrei Karas
2016-09-07 11:29 ` Gerd Hoffmann [this message]
2016-09-07 12:43 ` Andrei Karas
-- strict thread matches above, loose matches on Subject: below --
2016-08-23 20:29 Andrei Karas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473247771.28663.63.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=akaras@inbox.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).