* [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM.
@ 2016-08-23 20:37 Andrei Karas
2016-09-07 11:29 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Andrei Karas @ 2016-08-23 20:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Signed-off-by: Andrei Karas <akaras@inbox.ru>
---
ui/sdl2.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 4441e99..9523f64 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -584,9 +584,6 @@ static void handle_windowevent(SDL_Event *ev)
}
break;
case SDL_WINDOWEVENT_HIDDEN:
- if (!scon->hidden) {
- SDL_ShowWindow(scon->real_window);
- }
break;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM.
2016-08-23 20:37 [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM Andrei Karas
@ 2016-09-07 11:29 ` Gerd Hoffmann
2016-09-07 12:43 ` Andrei Karas
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2016-09-07 11:29 UTC (permalink / raw)
To: Andrei Karas; +Cc: qemu-devel
On Di, 2016-08-23 at 23:37 +0300, Andrei Karas wrote:
> Signed-off-by: Andrei Karas <akaras@inbox.ru>
> ---
> ui/sdl2.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index 4441e99..9523f64 100644
> --- a/ui/sdl2.c
> +++ b/ui/sdl2.c
> @@ -584,9 +584,6 @@ static void handle_windowevent(SDL_Event *ev)
> }
> break;
> case SDL_WINDOWEVENT_HIDDEN:
> - if (!scon->hidden) {
> - SDL_ShowWindow(scon->real_window);
> - }
Ok, but we should update scon->hidden with the new state then I guess?
And probably also in case the DE/WM shows the window again?
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM.
2016-09-07 11:29 ` Gerd Hoffmann
@ 2016-09-07 12:43 ` Andrei Karas
0 siblings, 0 replies; 4+ messages in thread
From: Andrei Karas @ 2016-09-07 12:43 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
>Среда, 7 сентября 2016, 14:29 +03:00 от Gerd Hoffmann <kraxel@redhat.com>:
>
>On Di, 2016-08-23 at 23:37 +0300, Andrei Karas wrote:
>> Signed-off-by: Andrei Karas < akaras@inbox.ru >
>> ---
>> ui/sdl2.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/ui/sdl2.c b/ui/sdl2.c
>> index 4441e99..9523f64 100644
>> --- a/ui/sdl2.c
>> +++ b/ui/sdl2.c
>> @@ -584,9 +584,6 @@ static void handle_windowevent(SDL_Event *ev)
>> }
>> break;
>> case SDL_WINDOWEVENT_HIDDEN:
>> - if (!scon->hidden) {
>> - SDL_ShowWindow(scon->real_window);
>> - }
>
>Ok, but we should update scon->hidden with the new state then I guess?
>And probably also in case the DE/WM shows the window again?
Issue what i solved here is. On hide event from DE/WM old code try to show window.
This is mistake.
I will try to update scon->hidden on show/hide WM event.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM.
@ 2016-08-23 20:29 Andrei Karas
0 siblings, 0 replies; 4+ messages in thread
From: Andrei Karas @ 2016-08-23 20:29 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Signed-off-by: Andrei Karas <akaras@inbox.ru>
---
ui/sdl2.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 4441e99..9523f64 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -584,9 +584,6 @@ static void handle_windowevent(SDL_Event *ev)
}
break;
case SDL_WINDOWEVENT_HIDDEN:
- if (!scon->hidden) {
- SDL_ShowWindow(scon->real_window);
- }
break;
}
}
--
2.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-07 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-23 20:37 [Qemu-devel] [PATCH 2/2] SDL2: dont try show window if it was hidden by DE/WM Andrei Karas
2016-09-07 11:29 ` Gerd Hoffmann
2016-09-07 12:43 ` Andrei Karas
-- strict thread matches above, loose matches on Subject: below --
2016-08-23 20:29 Andrei Karas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).