From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bheet-0000s5-Bq for qemu-devel@nongnu.org; Wed, 07 Sep 2016 11:21:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bheep-0003Q7-Nk for qemu-devel@nongnu.org; Wed, 07 Sep 2016 11:21:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bheep-0003Q1-Hr for qemu-devel@nongnu.org; Wed, 07 Sep 2016 11:20:59 -0400 From: Ladi Prosek Date: Wed, 7 Sep 2016 17:20:47 +0200 Message-Id: <1473261649-31465-2-git-send-email-lprosek@redhat.com> In-Reply-To: <1473261649-31465-1-git-send-email-lprosek@redhat.com> References: <1473261649-31465-1-git-send-email-lprosek@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] virtio-balloon: discard virtqueue element on reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com, rkagan@virtuozzo.com, stefanha@redhat.com, lprosek@redhat.com The one pending element is being freed but not discarded on device reset, which causes svq->inuse to creep up, eventually hitting the "Virtqueue size exceeded" error. Properly discarding the element on device reset makes sure that its buffers are unmapped and the inuse counter stays balanced. Cc: Michael S. Tsirkin Cc: Roman Kagan Cc: Stefan Hajnoczi Signed-off-by: Ladi Prosek --- hw/virtio/virtio-balloon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index 5af429a..ad4189a 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -463,6 +463,7 @@ static void virtio_balloon_device_reset(VirtIODevice *vdev) VirtIOBalloon *s = VIRTIO_BALLOON(vdev); if (s->stats_vq_elem != NULL) { + virtqueue_discard(s->svq, s->stats_vq_elem, 0); g_free(s->stats_vq_elem); s->stats_vq_elem = NULL; } -- 2.5.5