From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59845)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bhki6-0000ad-KO
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 17:48:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <benh@kernel.crashing.org>) id 1bhki1-0001dD-J1
	for qemu-devel@nongnu.org; Wed, 07 Sep 2016 17:48:46 -0400
Message-ID: <1473284892.8689.79.camel@kernel.crashing.org>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Thu, 08 Sep 2016 07:48:12 +1000
In-Reply-To: <3f9f94c6-961e-dcf6-3308-6419e47442c9@kaod.org>
References: <1466545735-2555-2-git-send-email-clg@kaod.org>
	<20160622024622.GK17957@voom.fritz.box>
	<c95690fb-b030-993c-3242-294b6eb63b5a@kaod.org>
	<20160623055002.GC17152@voom.fritz.box>
	<0578ae08-dd95-d517-318e-61b06148321a@redhat.com>
	<96938c4d-4786-6de0-ed45-9598beb28268@kaod.org>
	<01b2c7ef-ec04-caba-6ccc-96c77c98f98b@ilande.co.uk>
	<20160906001640.GA2900@voom.fritz.box>
	<050980a0-52cc-24ee-1416-d8c8edf959bf@ilande.co.uk>
	<9eb184de-1c1b-7a8b-3dcb-edfe3143f9b4@kaod.org>
	<1473246508.8689.71.camel@kernel.crashing.org>
	<3f9f94c6-961e-dcf6-3308-6419e47442c9@kaod.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 01/10] ppc: Fix rfi/rfid/hrfi/...
 emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?C=E9dric?= Le Goater <clg@kaod.org>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, David Gibson <david@gibson.dropbear.id.au>
Cc: Thomas Huth <thuth@redhat.com>, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Wed, 2016-09-07 at 14:13 +0200, C=C3=A9dric Le Goater wrote:
> On 09/07/2016 01:08 PM, Benjamin Herrenschmidt wrote:
> >=20
> > On Wed, 2016-09-07 at 12:50 +0200, C=C3=A9dric Le Goater wrote:
> > >=20
> > > This is a bit broader than Ben's patch which used
> > > PPC_SEGMENT_64B.=C2=A0
> > > it's basically !PPC_64B which includes the e5500.
> > >=20
> > > If so, here is a proposal below adding a new PPC_RFI in the=C2=A0
> > > "PowerPC Instructions types definitions" enum for that purpose.=C2=A0
> > > Not much bits left there.
> >=20
> > Why not stick to PPC_SEGMENT_64B ?
>=20
> I am trying to remove the rfi instruction from the set of the CPU=C2=A0
> and I think we need to introduce a new PPC_* bit for GEN_HANDLER to :

What does it buy you instead of just having the test in the handler ?

> +GEN_HANDLER(rfi, 0x13, 0x12, 0x01, 0x03FF8001, PPC_RFI),
>=20
> we can also keep the test on PPC_SEGMENT_64B in the handler which=C2=A0
> works perfectly fine.=C2=A0
>=20
> >=20
> > rfi exists on all 32-bit processors and all non-Book3S (aka server
> > aka
> > segment/hash) 64-bit. So PPC_SEGMENT_64B is the test we want.
> >=20
> > IE. rfi does exist on e5500
>=20
> ok.
>=20
> Cheers,
> C.