From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biSVQ-00069k-Ok for qemu-devel@nongnu.org; Fri, 09 Sep 2016 16:34:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1biSVM-0005TZ-QQ for qemu-devel@nongnu.org; Fri, 09 Sep 2016 16:34:35 -0400 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:33188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1biSVM-0005TL-Jz for qemu-devel@nongnu.org; Fri, 09 Sep 2016 16:34:32 -0400 Received: by mail-pf0-x242.google.com with SMTP id 128so4460825pfb.0 for ; Fri, 09 Sep 2016 13:34:32 -0700 (PDT) From: Ashijeet Acharya Date: Sat, 10 Sep 2016 02:03:36 +0530 Message-Id: <1473453216-529-1-git-send-email-ashijeetacharya@gmail.com> Subject: [Qemu-devel] [PATCH v2] migrate: Fix bounds check for migration parameters in migration.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: amit.shah@redhat.com, dgilbert@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, Ashijeet Acharya This patch fixes the out-of-bounds check of migration parameters in qmp_migrate_set_parameters() for cpu-throttle-initial and cpu-throttle-increment by adding a return statement for both as they were broken since their introduction in 2.5 via commit 1626fee. Due to the missing return statements, parameters were getting set to out-of-bounds values despite the error. Signed-off-by: Ashijeet Acharya --- migration/migration.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 9b4aa55..cd8334c 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -805,6 +805,7 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp) error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu_throttle_initial", "an integer in the range of 1 to 99"); + return; } if (params->has_cpu_throttle_increment && (params->cpu_throttle_increment < 1 || @@ -812,6 +813,7 @@ void qmp_migrate_set_parameters(MigrationParameters *params, Error **errp) error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "cpu_throttle_increment", "an integer in the range of 1 to 99"); + return; } if (params->has_max_bandwidth && (params->max_bandwidth < 0 || params->max_bandwidth > SIZE_MAX)) { -- 2.6.2