From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjgUB-0007VO-JF for qemu-devel@nongnu.org; Tue, 13 Sep 2016 01:42:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjgUA-0000BN-KJ for qemu-devel@nongnu.org; Tue, 13 Sep 2016 01:42:23 -0400 From: Jeff Cody Date: Tue, 13 Sep 2016 01:42:13 -0400 Message-Id: <1473745333-7548-3-git-send-email-jcody@redhat.com> In-Reply-To: <1473745333-7548-1-git-send-email-jcody@redhat.com> References: <1473745333-7548-1-git-send-email-jcody@redhat.com> Subject: [Qemu-devel] [PULL 2/2] qapi/block-core: add doc describing GlusterServer vs. SocketAddress List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: peter.maydell@linaro.org, jcody@redhat.com, qemu-devel@nongnu.org From: Prasanna Kumar Kalever Added documentation describing relation between GlusterServer and SocketAddress qapi schemas. Thanks to Markus Armbruster Reviewed-by: Markus Armbruster Reviewed-by: Jeff Cody Signed-off-by: Prasanna Kumar Kalever Message-id: 1471715924-3642-1-git-send-email-prasanna.kalever@redhat.com Signed-off-by: Jeff Cody --- qapi/block-core.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index 59128f7..173fb08 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2133,6 +2133,18 @@ # # @tcp: host address and port number # +# This is similar to SocketAddress, only distinction: +# +# 1. GlusterServer is a flat union, SocketAddress is a simple union. +# A flat union is nicer than simple because it avoids nesting +# (i.e. more {}) on the wire. +# +# 2. GlusterServer lacks case 'fd', since gluster doesn't let you +# pass in a file descriptor. +# +# GlusterServer is actually not Gluster-specific, its a +# compatibility evolved into an alternate for SocketAddress. +# # Since: 2.7 ## { 'union': 'GlusterServer', -- 2.7.4