qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Laurent Vivier <lvivier@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PULL v2 18/19] tests: fix qvirtqueue_kick
Date: Tue, 13 Sep 2016 11:02:46 +0100	[thread overview]
Message-ID: <1473760967-31840-19-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1473760967-31840-1-git-send-email-stefanha@redhat.com>

From: Laurent Vivier <lvivier@redhat.com>

vq->avail.idx and vq->avail->ring[] are a 16bit values,
so read and write them with readw()/writew() instead of
readl()/writel().

To read/write a 16bit value with a 32bit accessor works fine
on little-endian CPU but not on big endian CPU.

[An equivalent patch for the writew() calls was also sent by
Zhang Shuai <zhangshuai13@huawei.com>.
--Stefan]

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Message-id: 1472330054-22607-1-git-send-email-lvivier@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/libqos/virtio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/libqos/virtio.c b/tests/libqos/virtio.c
index d8c2970..37ff860 100644
--- a/tests/libqos/virtio.c
+++ b/tests/libqos/virtio.c
@@ -257,16 +257,16 @@ void qvirtqueue_kick(const QVirtioBus *bus, QVirtioDevice *d, QVirtQueue *vq,
                                                             uint32_t free_head)
 {
     /* vq->avail->idx */
-    uint16_t idx = readl(vq->avail + 2);
+    uint16_t idx = readw(vq->avail + 2);
     /* vq->used->flags */
     uint16_t flags;
     /* vq->used->avail_event */
     uint16_t avail_event;
 
     /* vq->avail->ring[idx % vq->size] */
-    writel(vq->avail + 4 + (2 * (idx % vq->size)), free_head);
+    writew(vq->avail + 4 + (2 * (idx % vq->size)), free_head);
     /* vq->avail->idx */
-    writel(vq->avail + 2, idx + 1);
+    writew(vq->avail + 2, idx + 1);
 
     /* Must read after idx is updated */
     flags = readw(vq->avail);
-- 
2.7.4

  parent reply	other threads:[~2016-09-13 10:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 10:02 [Qemu-devel] [PULL v2 00/19] Block patches Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 01/19] qcow2: avoid memcpy(dst, NULL, len) Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 02/19] linux-aio: consume events in userspace instead of calling io_getevents Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 03/19] linux-aio: split processing events function Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 04/19] linux-aio: process completions from ioq_submit() Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 05/19] virtio-blk: rename virtio_device_info to virtio_blk_info Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 06/19] block: unblock backup operations in backing file Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 07/19] Backup: clear all bitmap when doing block checkpoint Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 08/19] Backup: export interfaces for extra serialization Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 09/19] block: Link backup into block core Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 10/19] docs: block replication's description Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 11/19] mirror: auto complete active commit Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 12/19] configure: support replication Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 13/19] replication: Introduce new APIs to do replication operation Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 14/19] replication: Implement new driver for block replication Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 15/19] tests: add unit test case for replication Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 16/19] support replication driver in blockdev-add Stefan Hajnoczi
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 17/19] MAINTAINERS: add maintainer for replication Stefan Hajnoczi
2016-09-13 10:02 ` Stefan Hajnoczi [this message]
2016-09-13 10:02 ` [Qemu-devel] [PULL v2 19/19] iothread: Stop threads before main() quits Stefan Hajnoczi
2016-09-13 14:33 ` [Qemu-devel] [PULL v2 00/19] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473760967-31840-19-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).