From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjkYa-0005Mk-Us for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:03:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjkYS-0001lm-Oj for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:03:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjkYS-0001lg-JW for qemu-devel@nongnu.org; Tue, 13 Sep 2016 06:03:04 -0400 From: Stefan Hajnoczi Date: Tue, 13 Sep 2016 11:02:34 +0100 Message-Id: <1473760967-31840-7-git-send-email-stefanha@redhat.com> In-Reply-To: <1473760967-31840-1-git-send-email-stefanha@redhat.com> References: <1473760967-31840-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL v2 06/19] block: unblock backup operations in backing file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Wen Congyang , Changlong Xie , Wang WeiWei , Stefan Hajnoczi From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Reviewed-by: Stefan Hajnoczi Kashyap Chamarthy Message-id: 1469602913-20979-2-git-send-email-xiecl.fnst@cn.fujitsu.com Signed-off-by: Stefan Hajnoczi --- block.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 101f8c6..66ed1c0 100644 --- a/block.c +++ b/block.c @@ -1312,6 +1312,23 @@ void bdrv_set_backing_hd(BlockDriverState *bs, BlockDriverState *backing_hd) /* Otherwise we won't be able to commit due to check in bdrv_commit */ bdrv_op_unblock(backing_hd, BLOCK_OP_TYPE_COMMIT_TARGET, bs->backing_blocker); + /* + * We do backup in 3 ways: + * 1. drive backup + * The target bs is new opened, and the source is top BDS + * 2. blockdev backup + * Both the source and the target are top BDSes. + * 3. internal backup(used for block replication) + * Both the source and the target are backing file + * + * In case 1 and 2, neither the source nor the target is the backing file. + * In case 3, we will block the top BDS, so there is only one block job + * for the top BDS and its backing chain. + */ + bdrv_op_unblock(backing_hd, BLOCK_OP_TYPE_BACKUP_SOURCE, + bs->backing_blocker); + bdrv_op_unblock(backing_hd, BLOCK_OP_TYPE_BACKUP_TARGET, + bs->backing_blocker); out: bdrv_refresh_limits(bs, NULL); } -- 2.7.4